linux-kernel - Re: [PATCH v2] perf list: Display hybrid pmu events with cpu type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2bf7048d-2c20-8d3f-1b37-18a4056490a3@huawei.com>
Date:   Wed, 15 Dec 2021 17:34:32 +0000
From:   John Garry <john.garry@...wei.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
CC:     <jolsa@...nel.org>, <peterz@...radead.org>, <mingo@...hat.com>,
        <alexander.shishkin@...ux.intel.com>,
        <Linux-kernel@...r.kernel.org>, <linux-perf-users@...r.kernel.org>,
        <ak@...ux.intel.com>, <kan.liang@...el.com>,
        "irogers@...gle.com" <irogers@...gle.com>
Subject: Re: [PATCH v2] perf list: Display hybrid pmu events with cpu type

On 15/12/2021 16:18, John Garry wrote:

- yao.jin@...ux.intel.com, yao.jin@...el.com

Both these author addresses bounce for me :(

And it's not just my arm64 platform which is damaged, but also my x86 
broadwell machine - uncore aliasing for perf list is broken

Before snippet:
unc_cbo_cache_lookup.any_es
[Unit: uncore_cbox L3 Lookup any request that access cache and found 
line in E or S-state]
unc_cbo_cache_lookup.any_i
[Unit: uncore_cbox L3 Lookup any request that access cache and found 
line in I-state]

After snippet:
unc_cbo_cache_lookup.any_es
[Unit: uncore_cbox L3 Lookup any request that access cache and found 
line in E or S-state]
unc_cbo_cache_lookup.any_es
[Unit: uncore_cbox L3 Lookup any request that access cache and found 
line in E or S-state]
unc_cbo_cache_lookup.any_i
[Unit: uncore_cbox L3 Lookup any request that access cache and found 
line in I-state]
unc_cbo_cache_lookup.any_i
[Unit: uncore_cbox L3 Lookup any request that access cache and found 
line in I-state]

Notice how the events are repeated (twice, for each cbox PMU) after, 
when they should not be.

This seems to be the broken code added in print_pmu_events():

 > qsort(aliases, len, sizeof(struct sevent), cmp_sevent);
 > for (j = 0; j < len; j++) {
 > /* Skip duplicates */
 > - if (j > 0 && !strcmp(aliases[j].name, aliases[j - 1].name))
 > - continue;
 > + if (j > 0 && !strcmp(aliases[j].name, aliases[j - 1].name)) {
 > + if (!aliases[j].pmu || !aliases[j - 1].pmu ||
 > + !strcmp(aliases[j].pmu, aliases[j - 1].pmu)) {
 > + continue;
 > + }
 > + }

Anyone an idea on the !strcmp(aliases[j].pmu, aliases[j - 1].pmu) check 
or how to fix it?

Thanks,
John