linux-kernel - Re: [PATCH 2/3] perf script: Fix CPU filtering of a script's switch events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM9d7cirFVsiRmqCSnzM3Q22nvq+WBkiKrYZ21FZ4Pa4trnZrQ@mail.gmail.com>
Date:   Wed, 15 Dec 2021 10:05:40 -0800
From:   Namhyung Kim <namhyung@...nel.org>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Riccardo Mancini <rickyman7@...il.com>
Subject: Re: [PATCH 2/3] perf script: Fix CPU filtering of a script's switch events

On Wed, Dec 15, 2021 at 12:07 AM Adrian Hunter <adrian.hunter@...el.com> wrote:
>
> CPU filtering was not being applied to a script's switch events.
>
> Fixes: 5bf83c29a0ad2 ("perf script: Add scripting operation process_switch()")
> Cc: stable@...r.kernel.org
> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>

Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks,
Namhyung

> ---
>  tools/perf/builtin-script.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 9434367af166..c82b033e8942 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -2473,7 +2473,7 @@ static int process_switch_event(struct perf_tool *tool,
>         if (perf_event__process_switch(tool, event, sample, machine) < 0)
>                 return -1;
>
> -       if (scripting_ops && scripting_ops->process_switch)
> +       if (scripting_ops && scripting_ops->process_switch && !filter_cpu(sample))
>                 scripting_ops->process_switch(event, sample, machine);
>
>         if (!script->show_switch_events)
> --
> 2.25.1
>