linux-kernel - Re: [PATCH 1/2] dt-bindings: i2c: tegra: Add SMBus feature properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ybo16aNZ5MBW6XY6@robh.at.kernel.org>
Date:   Wed, 15 Dec 2021 12:37:29 -0600
From:   Rob Herring <robh@...nel.org>
To:     Akhil R <akhilrajeev@...dia.com>
Cc:     andy.shevchenko@...il.com, christian.koenig@....com,
        digetx@...il.com, dri-devel@...ts.freedesktop.org,
        jonathanh@...dia.com, ldewangan@...dia.com,
        linaro-mm-sig@...ts.linaro.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
        linux-tegra@...r.kernel.org, p.zabel@...gutronix.de,
        sumit.semwal@...aro.org, thierry.reding@...il.com,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: i2c: tegra: Add SMBus feature properties

On Thu, Dec 09, 2021 at 08:35:20PM +0530, Akhil R wrote:
> Tegra I2C can use a gpio as an smbus-alert. Document the usage of
> the same.
> 
> Signed-off-by: Akhil R <akhilrajeev@...dia.com>
> ---
>  Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt
> index 3f2f990..71ee79b 100644
> --- a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt
> +++ b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt
> @@ -70,6 +70,10 @@ Required properties:
>    - rx
>    - tx
>  
> +optional properties:
> +- smbalert-gpio: Must contain an entry for the gpio to be used as smbus alert.
> +  It will be used only if optional smbus-alert property is present.

There's already a standard way to do this with interrupts. And GPIOs can 
be interrupts usually.

> +
>  Example:
>  
>  	i2c@...0c000 {
> -- 
> 2.7.4
> 
>