linux-kernel - Re: [PATCH] of: unneed to initialise statics to 0 or NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YbpLDxhsSW43kMKj@robh.at.kernel.org>
Date:   Wed, 15 Dec 2021 14:07:43 -0600
From:   Rob Herring <robh@...nel.org>
To:     Jason Wang <wangborong@...rlc.com>
Cc:     frowand.list@...il.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of: unneed to initialise statics to 0 or NULL

On Sun, Dec 12, 2021 at 03:14:54PM +0800, Jason Wang wrote:
> Static variables do not need to be initialised to 0 or NULL,
> because compilers will initialise all uninitialised statics
> to 0 or NULL. Thus, remove the unneeded initializations.
> 

Not required, but I think it helps statics stand out more as-is.

> Signed-off-by: Jason Wang <wangborong@...rlc.com>
> ---
>  drivers/of/pdt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/of/pdt.c b/drivers/of/pdt.c
> index 7eda43c66c91..37d02fcb81d0 100644
> --- a/drivers/of/pdt.c
> +++ b/drivers/of/pdt.c
> @@ -40,7 +40,7 @@ static inline void irq_trans_init(struct device_node *dp) { }
>  
>  static char * __init of_pdt_build_full_name(struct device_node *dp)
>  {
> -	static int failsafe_id = 0; /* for generating unique names on failure */
> +	static int failsafe_id; /* for generating unique names on failure */
>  	const char *name;
>  	char path[256];
>  	char *buf;
> @@ -67,7 +67,7 @@ static struct property * __init of_pdt_build_one_prop(phandle node, char *prev,
>  					       void *special_val,
>  					       int special_len)
>  {
> -	static struct property *tmp = NULL;
> +	static struct property *tmp;
>  	struct property *p;
>  	int err;
>  
> -- 
> 2.34.1
> 
>