linux-kernel - Re: [PATCH] drm/tilcdc: add const to of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Dec 2021 04:35:33 +0800
From:   kernel test robot <lkp@...el.com>
To:     Xiang wangx <wangxiang@...rlc.com>, jyri.sarha@....fi
Cc:     kbuild-all@...ts.01.org, Xiang wangx <wangxiang@...rlc.com>,
        tomba@...nel.org, airlied@...ux.ie, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/tilcdc: add const to of_device_id

Hi Xiang,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm/drm-next]
[also build test ERROR on v5.16-rc5 next-20211214]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Xiang-wangx/drm-tilcdc-add-const-to-of_device_id/20211216-002326
base:   git://anongit.freedesktop.org/drm/drm drm-next
config: arm-randconfig-c002-20211214 (https://download.01.org/0day-ci/archive/20211216/202112160411.sNrSELAY-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/5698eadb76d94a4fc5298f5bea88b839399ddef0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Xiang-wangx/drm-tilcdc-add-const-to-of_device_id/20211216-002326
        git checkout 5698eadb76d94a4fc5298f5bea88b839399ddef0
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash drivers/gpu/drm/tilcdc/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/tilcdc/tilcdc_drv.c:590:34: error: conflicting types for 'tilcdc_of_match'; have 'const struct of_device_id[]'
     590 | static const struct of_device_id tilcdc_of_match[] = {
         |                                  ^~~~~~~~~~~~~~~
   drivers/gpu/drm/tilcdc/tilcdc_drv.c:63:28: note: previous declaration of 'tilcdc_of_match' with type 'struct of_device_id[]'
      63 | static struct of_device_id tilcdc_of_match[];
         |                            ^~~~~~~~~~~~~~~
   drivers/gpu/drm/tilcdc/tilcdc_drv.c:63:28: error: array 'tilcdc_of_match' assumed to have one element [-Werror]
>> drivers/gpu/drm/tilcdc/tilcdc_drv.c:63:28: error: 'tilcdc_of_match' defined but not used [-Werror=unused-variable]
   cc1: all warnings being treated as errors


vim +590 drivers/gpu/drm/tilcdc/tilcdc_drv.c

   589	
 > 590	static const struct of_device_id tilcdc_of_match[] = {
   591			{ .compatible = "ti,am33xx-tilcdc", },
   592			{ .compatible = "ti,da850-tilcdc", },
   593			{ },
   594	};
   595	MODULE_DEVICE_TABLE(of, tilcdc_of_match);
   596	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org