linux-kernel - Re: [PATCH v2] media: aspeed: move err-handling together to the bottom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <851a6a45-f132-463a-2d4b-1248202aa60b@aspeedtech.com>
Date:   Wed, 15 Dec 2021 09:59:59 +0800
From:   Jammy Huang <jammy_huang@...eedtech.com>
To:     Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
CC:     "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        "andrew@...id.au" <andrew@...id.au>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>,
        "eajames@...ux.ibm.com" <eajames@...ux.ibm.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "laurent.pinchart@...asonboard.com" 
        <laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH v2] media: aspeed: move err-handling together to the
 bottom

Hi Sakari,

Thanks for your review.

On 2021/12/15 上午 02:32, Sakari Ailus wrote:
> Hi Mauro,
>
> On Tue, Dec 14, 2021 at 03:53:00PM +0100, Mauro Carvalho Chehab wrote:
>> Em Mon, 6 Dec 2021 08:48:11 +0800
>> Jammy Huang <jammy_huang@...eedtech.com> escreveu:
>>
>>> refine aspeed_video_setup_video() flow.
>> Why? It makes no difference where the error handling code is. Let's
>> keep it as preferred by the driver's author ;-)
> Doing error handling can be done in different ways of course, but I think
> it's easier to see it's right as it's done by this patch. Of course the
> original author's --- like anyone else's --- review wouldn't hurt. But I
> see he hasn't reviewed other recent patches to the driver either.
>
> A better description would be nice though, including capital letter
> beginning a sentence.
>
>> Regards,
>> Mauro
>>
>>> Signed-off-by: Jammy Huang <jammy_huang@...eedtech.com>
>>> ---
>>> v2:
>>>   - remove change-id in comment
>>> ---
>>>   drivers/media/platform/aspeed-video.c | 24 +++++++++++-------------
>>>   1 file changed, 11 insertions(+), 13 deletions(-)
>>>
>>> diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c
>>> index fea5e4d0927e..f5c40d6b4ece 100644
>>> --- a/drivers/media/platform/aspeed-video.c
>>> +++ b/drivers/media/platform/aspeed-video.c
>>> @@ -1641,11 +1641,8 @@ static int aspeed_video_setup_video(struct aspeed_video *video)
>>>   
>>>   	rc = video->ctrl_handler.error;
>>>   	if (rc) {
>>> -		v4l2_ctrl_handler_free(&video->ctrl_handler);
>>> -		v4l2_device_unregister(v4l2_dev);
>>> -
>>>   		dev_err(video->dev, "Failed to init controls: %d\n", rc);
>>> -		return rc;
>>> +		goto err_ctrl_init;
>>>   	}
>>>   
>>>   	v4l2_dev->ctrl_handler = &video->ctrl_handler;
>>> @@ -1663,11 +1660,8 @@ static int aspeed_video_setup_video(struct aspeed_video *video)
>>>   
>>>   	rc = vb2_queue_init(vbq);
>>>   	if (rc) {
>>> -		v4l2_ctrl_handler_free(&video->ctrl_handler);
>>> -		v4l2_device_unregister(v4l2_dev);
>>> -
>>>   		dev_err(video->dev, "Failed to init vb2 queue\n");
>>> -		return rc;
>>> +		goto err_vb2_init;
>>>   	}
>>>   
>>>   	vdev->queue = vbq;
>>> @@ -1685,15 +1679,19 @@ static int aspeed_video_setup_video(struct aspeed_video *video)
>>>   	video_set_drvdata(vdev, video);
>>>   	rc = video_register_device(vdev, VFL_TYPE_GRABBER, 0);
>>>   	if (rc) {
>>> -		vb2_queue_release(vbq);
>>> -		v4l2_ctrl_handler_free(&video->ctrl_handler);
>>> -		v4l2_device_unregister(v4l2_dev);
>>> -
>>>   		dev_err(video->dev, "Failed to register video device\n");
>>> -		return rc;
>>> +		goto err_video_reg;
>>>   	}
>>>   
>>>   	return 0;
>>> +
>>> +err_video_reg:
>>> +	vb2_queue_release(vbq);
>>> +err_vb2_init:
>>> +err_ctrl_init:
>>> +	v4l2_ctrl_handler_free(&video->ctrl_handler);
>>> +	v4l2_device_unregister(v4l2_dev);
>>> +	return rc;
>>>   }
>>>   
>>>   static int aspeed_video_init(struct aspeed_video *video)
>>
>>
>> Thanks,
>> Mauro

-- 
Best Regards
Jammy