linux-kernel - Re: [PATCH v2 12/18] crypto: dh - introduce support for ephemeral key generation to qat driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YbpkGtH6dYCXNOZu@silpixa00400314>
Date:   Wed, 15 Dec 2021 21:54:34 +0000
From:   Giovanni Cabiddu <giovanni.cabiddu@...el.com>
To:     Nicolai Stange <nstange@...e.de>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Stephan Müller <smueller@...onox.de>,
        Hannes Reinecke <hare@...e.de>, Torsten Duwe <duwe@...e.de>,
        Zaibo Xu <xuzaibo@...wei.com>,
        David Howells <dhowells@...hat.com>,
        Jarkko Sakkinen <jarkko@...nel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        qat-linux <qat-linux@...el.com>,
        "keyrings@...r.kernel.org" <keyrings@...r.kernel.org>
Subject: Re: [PATCH v2 12/18] crypto: dh - introduce support for ephemeral
 key generation to qat driver

On Thu, Dec 09, 2021 at 09:03:52AM +0000, Nicolai Stange wrote:
> A previous patch made the dh-generic implementation's ->set_secret() to
> generate an ephemeral key in case the input ->key_size is zero, just in
> analogy with ecdh. Make the qat crypto driver's DH implementation to
> behave consistently by doing the same.
I ran a few tests on QAT GEN2 HW and this patch/set does not causes
regressions.

On the headline of the commit, should this be crypto: qat - ... ?

> Signed-off-by: Nicolai Stange <nstange@...e.de>
> Reviewed-by: Hannes Reinecke <hare@...e.de>
 Acked-by: Giovanni Cabiddu <giovanni.cabiddu@...el.com>

-- 
Giovanni