linux-kernel - Re: [PATCH v4 3/3] mmc: Add driver for LiteX's LiteSDCard interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACPK8XdP2Zcv4=psoFZGK+pQC514m2wri15vGZS=hWreOWoqTQ@mail.gmail.com>
Date:   Wed, 15 Dec 2021 02:37:51 +0000
From:   Joel Stanley <joel@....id.au>
To:     "Gabriel L. Somlo" <gsomlo@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        linux-mmc <linux-mmc@...r.kernel.org>,
        Karol Gugala <kgugala@...micro.com>,
        Mateusz Holenko <mholenko@...micro.com>,
        Kamil Rakoczy <krakoczy@...micro.com>,
        mdudek@...ernships.antmicro.com,
        Paul Mackerras <paulus@...abs.org>,
        Stafford Horne <shorne@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        david.abdurachmanov@...ive.com,
        Florent Kermarrec <florent@...oy-digital.fr>,
        Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH v4 3/3] mmc: Add driver for LiteX's LiteSDCard interface

On Sun, 12 Dec 2021 at 16:21, Gabriel L. Somlo <gsomlo@...il.com> wrote:
>
> Hi Joel,
>
> On Fri, Dec 10, 2021 at 09:54:30AM -0500, Gabriel Somlo wrote:
> > LiteX (https://github.com/enjoy-digital/litex) is a SoC framework
> > that targets FPGAs. LiteSDCard is a small footprint, configurable
> > SDCard core commonly used in LiteX designs.
> >
> > The driver was first written in May 2020 and has been maintained
> > cooperatively by the LiteX community. Thanks to all contributors!
> >
> > Co-developed-by: Kamil Rakoczy <krakoczy@...micro.com>
> > Signed-off-by: Kamil Rakoczy <krakoczy@...micro.com>
> > Co-developed-by: Maciej Dudek <mdudek@...ernships.antmicro.com>
> > Signed-off-by: Maciej Dudek <mdudek@...ernships.antmicro.com>
> > Co-developed-by: Paul Mackerras <paulus@...abs.org>
> > Signed-off-by: Paul Mackerras <paulus@...abs.org>
> > Signed-off-by: Gabriel Somlo <gsomlo@...il.com>


> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index 5af8494c31b5..c1b66d06d1c9 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -1093,3 +1093,12 @@ config MMC_OWL
> >
> >  config MMC_SDHCI_EXTERNAL_DMA
> >       bool
> > +
> > +config MMC_LITEX
> > +     tristate "LiteX MMC Host Controller support"
>
> I remembered I still owe you an answer on whether this was ever
> successfully tested as a module: The answer is *yes* -- if configured
> as a loadable module, it loads OK with modprobe, works fine, and can
> be unloaded (with `modprobe -r`) and re-loaded indefinitely.

Very good.

Thanks for following up on the suggestions I made.

Reviewed-by: Joel Stanley <joel@....id.au>

Cheers,

Joel