linux-kernel - include/linux/fortify-string.h:27:33: warning: '__builtin_strncpy' output may be truncated copying between 5 and 9 bytes from a string of length 9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 15 Dec 2021 08:00:36 +0800
From:   kernel test robot <lkp@...el.com>
To:     Francis Laniel <laniel_francis@...vacyrequired.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>
Subject: include/linux/fortify-string.h:27:33: warning: '__builtin_strncpy'
 output may be truncated copying between 5 and 9 bytes from a string of
 length 9

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   5472f14a37421d1bca3dddf33cabd3bd6dbefbbc
commit: a28a6e860c6cf231cf3c5171c75c342adcd00406 string.h: move fortified functions definitions in a dedicated header.
date:   10 months ago
config: mips-randconfig-r011-20211214 (https://download.01.org/0day-ci/archive/20211215/202112150718.rMIimid9-lkp@intel.com/config)
compiler: mipsel-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a28a6e860c6cf231cf3c5171c75c342adcd00406
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout a28a6e860c6cf231cf3c5171c75c342adcd00406
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash arch/mips/dec/prom/ fs/xfs/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/string.h:269,
                    from include/linux/uuid.h:12,
                    from fs/xfs/xfs_linux.h:10,
                    from fs/xfs/xfs.h:22,
                    from fs/xfs/xfs_xattr.c:7:
   In function 'strncpy',
       inlined from '__xfs_xattr_put_listent' at fs/xfs/xfs_xattr.c:119:2,
       inlined from 'xfs_xattr_put_listent' at fs/xfs/xfs_xattr.c:181:2:
>> include/linux/fortify-string.h:27:33: warning: '__builtin_strncpy' output may be truncated copying between 5 and 9 bytes from a string of length 9 [-Wstringop-truncation]
      27 | #define __underlying_strncpy    __builtin_strncpy
         |                                 ^
   include/linux/fortify-string.h:38:16: note: in expansion of macro '__underlying_strncpy'
      38 |         return __underlying_strncpy(p, q, size);
         |                ^~~~~~~~~~~~~~~~~~~~


vim +/__builtin_strncpy +27 include/linux/fortify-string.h

     4	
     5	
     6	#if defined(CONFIG_KASAN_GENERIC) || defined(CONFIG_KASAN_SW_TAGS)
     7	extern void *__underlying_memchr(const void *p, int c, __kernel_size_t size) __RENAME(memchr);
     8	extern int __underlying_memcmp(const void *p, const void *q, __kernel_size_t size) __RENAME(memcmp);
     9	extern void *__underlying_memcpy(void *p, const void *q, __kernel_size_t size) __RENAME(memcpy);
    10	extern void *__underlying_memmove(void *p, const void *q, __kernel_size_t size) __RENAME(memmove);
    11	extern void *__underlying_memset(void *p, int c, __kernel_size_t size) __RENAME(memset);
    12	extern char *__underlying_strcat(char *p, const char *q) __RENAME(strcat);
    13	extern char *__underlying_strcpy(char *p, const char *q) __RENAME(strcpy);
    14	extern __kernel_size_t __underlying_strlen(const char *p) __RENAME(strlen);
    15	extern char *__underlying_strncat(char *p, const char *q, __kernel_size_t count) __RENAME(strncat);
    16	extern char *__underlying_strncpy(char *p, const char *q, __kernel_size_t size) __RENAME(strncpy);
    17	#else
    18	#define __underlying_memchr	__builtin_memchr
    19	#define __underlying_memcmp	__builtin_memcmp
    20	#define __underlying_memcpy	__builtin_memcpy
    21	#define __underlying_memmove	__builtin_memmove
    22	#define __underlying_memset	__builtin_memset
    23	#define __underlying_strcat	__builtin_strcat
    24	#define __underlying_strcpy	__builtin_strcpy
    25	#define __underlying_strlen	__builtin_strlen
    26	#define __underlying_strncat	__builtin_strncat
  > 27	#define __underlying_strncpy	__builtin_strncpy
    28	#endif
    29	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org