linux-kernel - Re: [PATCH 2/2] fsi: sbefifo: implement FSI_SBEFIFO_READ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202112151543.C2qA1wIs-lkp@intel.com>
Date:   Wed, 15 Dec 2021 15:41:38 +0800
From:   kernel test robot <lkp@...el.com>
To:     Amitay Isaacs <amitay@...abs.org>, linux-kernel@...r.kernel.org,
        linux-fsi@...ts.ozlabs.org, jk@...abs.org, joel@....id.au,
        alistair@...ple.id.au, eajames@...ux.ibm.com
Cc:     kbuild-all@...ts.01.org, Amitay Isaacs <amitay@...abs.org>
Subject: Re: [PATCH 2/2] fsi: sbefifo: implement FSI_SBEFIFO_READ_TIMEOUT
 ioctl

Hi Amitay,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linux/master]
[also build test WARNING on linus/master v5.16-rc5 next-20211214]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Amitay-Isaacs/fsi-sbefifo-Use-specified-value-of-start-of-response-timeout/20211215-090038
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 136057256686de39cc3a07c2e39ef6bc43003ff6
config: h8300-randconfig-s032-20211214 (https://download.01.org/0day-ci/archive/20211215/202112151543.C2qA1wIs-lkp@intel.com/config)
compiler: h8300-linux-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/abe81bc06079f76e9a9f4ebe6cc0a963ee5b6985
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Amitay-Isaacs/fsi-sbefifo-Use-specified-value-of-start-of-response-timeout/20211215-090038
        git checkout abe81bc06079f76e9a9f4ebe6cc0a963ee5b6985
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=h8300 SHELL=/bin/bash drivers/fsi/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/fsi/fsi-sbefifo.c:956:31: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected void [noderef] __user **argp @@     got void [noderef] __user * @@
   drivers/fsi/fsi-sbefifo.c:956:31: sparse:     expected void [noderef] __user **argp
   drivers/fsi/fsi-sbefifo.c:956:31: sparse:     got void [noderef] __user *

vim +956 drivers/fsi/fsi-sbefifo.c

   952	
   953	static long sbefifo_user_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
   954	{
   955		struct sbefifo_user *user = file->private_data;
 > 956		void __user **argp = (void __user *)arg;
   957		int rc = -ENOTTY;
   958	
   959		if (!user)
   960			return -EINVAL;
   961	
   962		mutex_lock(&user->file_lock);
   963		switch (cmd) {
   964		case FSI_SBEFIFO_READ_TIMEOUT:
   965			rc = sbefifo_read_timeout(user, argp);
   966			break;
   967		}
   968		mutex_unlock(&user->file_lock);
   969		return rc;
   970	}
   971	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org