linux-kernel - Re: [PATCH] media: i2c: ov8865: Neaten unnecessary indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8541216a98a1a68fe6c339096e5e148a40b414e2.camel@perches.com>
Date:   Wed, 15 Dec 2021 00:07:14 -0800
From:   Joe Perches <joe@...ches.com>
To:     Sakari Ailus <sakari.ailus@....fi>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
        linux-media <linux-media@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] media: i2c: ov8865: Neaten unnecessary indentation

On Wed, 2021-12-15 at 10:01 +0200, Sakari Ailus wrote:
> Hi Joe
> 
> On Tue, Dec 07, 2021 at 06:47:45AM -0800, Joe Perches wrote:
> > On Tue, 2021-12-07 at 14:24 +0200, Sakari Ailus wrote:
> > > Hi Joe (and Paul),
> > 
> > > I guess this patch is fine as such but there seems to be a problem in error
> > > handling here: all regulators are disabled if there's a problem enabling
> > > one of them.
> > > 
> > > Would it be possible to fix this as well?
> > 
> > I've no hardware to test, so I've no idea if that's the right thing to do.
> 
> I don't have the hardware either.
> 
> But I can tell that you shouldn't disable a regulator you haven't enabled
> to begin with. Bugs (fixes of which probably should go to stable trees)
> need to be fixed before reworking the code.

I'm just fixing the ugly code.
You are welcome to fix what you believe to be logical defects.