linux-kernel - RE: [External] : [PATCH for-next v2] RDMA/rxe: remove redundant err variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Dec 2021 08:40:56 +0000
From:   Devesh Sharma <devesh.s.sharma@...cle.com>
To:     "cgel.zte@...il.com" <cgel.zte@...il.com>
CC:     "chi.minghao@....com.cn" <chi.minghao@....com.cn>,
        "dledford@...hat.com" <dledford@...hat.com>,
        "jgg@...pe.ca" <jgg@...pe.ca>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "zealci@....com.cn" <zealci@....com.cn>,
        "zyjzyj2000@...il.com" <zyjzyj2000@...il.com>
Subject: RE: [External] : [PATCH for-next v2] RDMA/rxe: remove redundant err
 variable



> -----Original Message-----
> From: cgel.zte@...il.com <cgel.zte@...il.com>
> Sent: Wednesday, December 15, 2021 1:23 PM
> To: Devesh Sharma <devesh.s.sharma@...cle.com>
> Cc: cgel.zte@...il.com; chi.minghao@....com.cn; dledford@...hat.com;
> jgg@...pe.ca; linux-kernel@...r.kernel.org; linux-rdma@...r.kernel.org;
> zealci@....com.cn; zyjzyj2000@...il.com
> Subject: [External] : [PATCH for-next v2] RDMA/rxe: remove redundant err
> variable
> 
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Return value directly instead of taking this in another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
> ---
>  drivers/infiniband/sw/rxe/rxe_net.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/infiniband/sw/rxe/rxe_net.c
> b/drivers/infiniband/sw/rxe/rxe_net.c
> index 2cb810cb890a..f557150bd59a 100644
> --- a/drivers/infiniband/sw/rxe/rxe_net.c
> +++ b/drivers/infiniband/sw/rxe/rxe_net.c
> @@ -22,24 +22,20 @@ static struct rxe_recv_sockets recv_sockets;
> 
>  int rxe_mcast_add(struct rxe_dev *rxe, union ib_gid *mgid)  {
> -	int err;
>  	unsigned char ll_addr[ETH_ALEN];
> 
>  	ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
> -	err = dev_mc_add(rxe->ndev, ll_addr);
> 
> -	return err;
> +	return dev_mc_add(rxe->ndev, ll_addr);
>  }
> 
>  int rxe_mcast_delete(struct rxe_dev *rxe, union ib_gid *mgid)  {
> -	int err;
>  	unsigned char ll_addr[ETH_ALEN];
> 
>  	ipv6_eth_mc_map((struct in6_addr *)mgid->raw, ll_addr);
> -	err = dev_mc_del(rxe->ndev, ll_addr);
> 
> -	return err;
> +	return dev_mc_del(rxe->ndev, ll_addr);
>  }
> 
LGTM
Reviewed-by: Devesh Sharma <Devesh.s.sharma@...cle.com>

>  static struct dst_entry *rxe_find_route4(struct net_device *ndev,
> --
> 2.25.1