lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <68aa97ae-dd76-5879-3dba-a08c3581f25b@suse.com>
Date:   Wed, 15 Dec 2021 09:55:39 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Jason Wang <wangborong@...rlc.com>
Cc:     boris.ostrovsky@...cle.com, sstabellini@...nel.org,
        xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xen/pciback: fix typo in a comment

On 12.12.21 04:24, Jason Wang wrote:
> The double `the' in the comment in line 163 is repeated. Remove it
> from the comment.
> 
> Signed-off-by: Jason Wang <wangborong@...rlc.com>
> ---
>   drivers/xen/xen-pciback/pciback_ops.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/xen/xen-pciback/pciback_ops.c b/drivers/xen/xen-pciback/pciback_ops.c
> index 3fbc21466a93..e38b43b5065e 100644
> --- a/drivers/xen/xen-pciback/pciback_ops.c
> +++ b/drivers/xen/xen-pciback/pciback_ops.c
> @@ -160,7 +160,7 @@ int xen_pcibk_enable_msi(struct xen_pcibk_device *pdev,
>   	}
>   
>   	/* The value the guest needs is actually the IDT vector, not the
> -	 * the local domain's IRQ number. */
> +	 * local domain's IRQ number. */

When touching this comment, would you mind to correct its style, too?
It should have a leading "/*" and a trailing "*/" line like e.g. in
line 72 of the same source file.


Juergen

Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3092 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (496 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ