linux-kernel - Re: [PATCH resend v3] reset: renesas: Fix Runtime PM usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0aaf9792fad706519da3c0177151dc2316882706.camel@pengutronix.de>
Date:   Wed, 15 Dec 2021 11:21:15 +0100
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Biju Das <biju.das.jz@...renesas.com>,
        Heiner Kallweit <hkallweit1@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH resend v3] reset: renesas: Fix Runtime PM usage

On Wed, 2021-12-15 at 10:18 +0000, Biju Das wrote:
> Hi Heiner,
> 
> Thanks for the patch.
> 
> > Subject: [PATCH resend v3] reset: renesas: Fix Runtime PM usage
> > 
> > If pm_runtime_resume_and_get() fails then it returns w/o the RPM usage
> > counter being incremented. In this case call pm_runtime_put() in
> > remove() will result in a usage counter imbalance. Therefore check the
> > return code of pm_runtime_resume_and_get() and bail out in case of error.
> > 
> > Fixes: bee08559701f ("reset: renesas: Add RZ/G2L usbphy control driver")
> > Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> 
> Reviewed-by: Biju Das <biju.das.jz@...renesas.com>

Thank you both, applied to reset/fixes.

regards
Philipp