linux-kernel - [rmk-arm:zii 147/186] drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1531:49: error: incompatible pointer types passing 'struct phylink_config *' to parameter of type 'struct phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202112151831.VAQ7h5FH-lkp@intel.com>
Date:   Wed, 15 Dec 2021 19:06:52 +0800
From:   kernel test robot <lkp@...el.com>
To:     "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: [rmk-arm:zii 147/186]
 drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1531:49: error:
 incompatible pointer types passing 'struct phylink_config *' to parameter of
 type 'struct phylink_pcs *'

tree:   git://git.armlinux.org.uk/~rmk/linux-arm zii
head:   d3ebd79d7fb6476e2409c147e4dcc304733f7ae6
commit: dc659b3d109e3e55a76c0ed143119dad7b369ec8 [147/186] net: axienet: convert to phylink_pcs
config: x86_64-randconfig-r016-20211214 (https://download.01.org/0day-ci/archive/20211215/202112151831.VAQ7h5FH-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project b6a2ddb6c8ac29412b1361810972e15221fa021c)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add rmk-arm git://git.armlinux.org.uk/~rmk/linux-arm
        git fetch --no-tags rmk-arm zii
        git checkout dc659b3d109e3e55a76c0ed143119dad7b369ec8
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/dsa/ drivers/net/ethernet/xilinx/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1531:49: error: incompatible pointer types passing 'struct phylink_config *' to parameter of type 'struct phylink_pcs *' [-Werror,-Wincompatible-pointer-types]
           struct net_device *ndev = pcs_to_axienet_local(pcs)->ndev;
                                                          ^~~
   drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1506:71: note: passing argument to parameter 'pcs' here
   static struct axienet_local *pcs_to_axienet_local(struct phylink_pcs *pcs)
                                                                         ^
   drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1532:53: error: incompatible pointer types passing 'struct phylink_config *' to parameter of type 'struct phylink_pcs *' [-Werror,-Wincompatible-pointer-types]
           struct mdio_device *pcs_phy = pcs_to_axienet_local(pcs)->pcs_phy;
                                                              ^~~
   drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1506:71: note: passing argument to parameter 'pcs' here
   static struct axienet_local *pcs_to_axienet_local(struct phylink_pcs *pcs)
                                                                         ^
>> drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1537:8: error: use of undeclared identifier 'iface'
                               iface == PHY_INTERFACE_MODE_SGMII ?
                               ^
>> drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1554:16: error: incompatible function pointer types initializing 'int (*)(struct phylink_pcs *, unsigned int, phy_interface_t, const unsigned long *, bool)' (aka 'int (*)(struct phylink_pcs *, unsigned int, phy_interface_t, const unsigned long *, _Bool)') with an expression of type 'int (struct phylink_config *, unsigned int, phy_interface_t, const unsigned long *, bool)' (aka 'int (struct phylink_config *, unsigned int, phy_interface_t, const unsigned long *, _Bool)') [-Werror,-Wincompatible-function-pointer-types]
           .pcs_config = axienet_pcs_config,
                         ^~~~~~~~~~~~~~~~~~
   4 errors generated.


vim +1531 drivers/net/ethernet/xilinx/xilinx_axienet_main.c

  1525	
  1526	static int axienet_pcs_config(struct phylink_config *pcs, unsigned int mode,
  1527				      phy_interface_t interface,
  1528				      const unsigned long *advertising,
  1529				      bool permit_pause_to_mac)
  1530	{
> 1531		struct net_device *ndev = pcs_to_axienet_local(pcs)->ndev;
  1532		struct mdio_device *pcs_phy = pcs_to_axienet_local(pcs)->pcs_phy;
  1533		int ret;
  1534	
  1535		ret = mdiobus_write(pcs_phy->bus, pcs_phy->addr,
  1536				    XLNX_MII_STD_SELECT_REG,
> 1537				    iface == PHY_INTERFACE_MODE_SGMII ?
  1538					XLNX_MII_STD_SELECT_SGMII : 0);
  1539		if (ret < 0) {
  1540			netdev_warn(ndev, "Failed to switch PHY interface: %d\n",
  1541				    ret);
  1542			return ret;
  1543		}
  1544	
  1545		ret = phylink_mii_c22_pcs_config(pcs_phy, mode, interface, advertising);
  1546		if (ret < 0)
  1547			netdev_warn(ndev, "Failed to configure PCS: %d\n", ret);
  1548	
  1549		return ret;
  1550	}
  1551	
  1552	static const struct phylink_pcs_ops axienet_pcs_ops = {
  1553		.pcs_get_state = axienet_pcs_get_state,
> 1554		.pcs_config = axienet_pcs_config,
  1555		.pcs_an_restart = axienet_pcs_an_restart,
  1556	};
  1557	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org