linux-kernel - Re: [RFC PATCH 1/1] perf arm64: Implement --topdown with metrics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a14914c-063d-f9ae-be49-ae9cc6aa7ff1@huawei.com>
Date:   Wed, 15 Dec 2021 12:53:16 +0000
From:   John Garry <john.garry@...wei.com>
To:     Andrew Kilroy <andrew.kilroy@....com>,
        Ian Rogers <irogers@...gle.com>
CC:     <linux-kernel@...r.kernel.org>, <linux-perf-users@...r.kernel.org>,
        <acme@...nel.org>, Will Deacon <will@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Leo Yan <leo.yan@...aro.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        "Namhyung Kim" <namhyung@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [RFC PATCH 1/1] perf arm64: Implement --topdown with metrics

>> In addition we could also add a --topdown arg to force using JSON 
>> metricgroups.
>>
> 
> What arg do think would be supplied?

something like -json or -metricgroup, meaning "Use pmu-events metric 
events to calculate topdown results rather than kernel CPU PMU events. 
This is default fallback if the kernel CPU PMU does not support topdown 
events"

> 
>> Did you actually test this patch? I have something experimental 
>> working from some time ago, and it was more complicated than this. I 
>> need to check the code again...
>>
> 
> I got stats back from this implementation, yes.  Let me know if there's 
> things my patch isn't catering for.

I'll give it a spin...

Thanks,
John