linux-kernel - Re: [PATCH v2 4/6] i2c: designware-pci: Fix to change data types of hcnt and lcnt parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ybny5Cxh60e7d63q@smile.fi.intel.com>
Date:   Wed, 15 Dec 2021 15:51:32 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Jarkko Nikula <jarkko.nikula@...ux.intel.com>
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Lakshmi Sowjanya D <lakshmi.sowjanya.d@...el.com>
Subject: Re: [PATCH v2 4/6] i2c: designware-pci: Fix to change data types of
 hcnt and lcnt parameters

On Wed, Dec 15, 2021 at 09:55:47AM +0200, Jarkko Nikula wrote:
> On 12/13/21 20:00, Andy Shevchenko wrote:
> > From: Lakshmi Sowjanya D <lakshmi.sowjanya.d@...el.com>
> > 
> > The data type of hcnt and lcnt in the struct dw_i2c_dev is of type u16.
> > It's better to have same data type in struct dw_scl_sda_cfg as well.

...

> I proposed this to be first before questionable cleanups since this fixes
> existing confusion (noted by Wolfram not any of us). Same to 5-6/6.

Okay, I postpone this series. It seems altogether it will require more time
than I currently have. Consider picking patches on the basis you have in mind
if you consider them useful. Thanks!

-- 
With Best Regards,
Andy Shevchenko