linux-kernel - Re: [PATCH v6 11/28] ARM: tegra: Add device-tree for ASUS Transformer Infinity TF700T

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Dec 2021 15:01:25 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Jonathan Hunter <jonathanh@...dia.com>,
        David Heidelberg <david@...t.cz>,
        Svyatoslav Ryhel <clamor95@...il.com>,
        Anton Bambura <jenneron@...tonmail.com>,
        Antoni Aloy Torrens <aaloytorrens@...il.com>,
        Nikola Milosavljevic <mnidza@...look.com>,
        Ion Agorria <ion@...rria.com>,
        Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        Ihor Didenko <tailormoon@...bler.ru>,
        Andreas Westman Dorcsak <hedmoo@...oo.com>,
        Maxim Schwalm <maxim.schwalm@...il.com>,
        Raffaele Tranquillini <raffaele.tranquillini@...il.com>,
        Jasper Korten <jja2000@...il.com>,
        Thomas Graichen <thomas.graichen@...il.com>,
        Stefan Eichenberger <stefan.eichenberger@...adex.com>,
        Stefan Agner <stefan@...er.ch>,
        Peter Geis <pgwipeout@...il.com>, devicetree@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 11/28] ARM: tegra: Add device-tree for ASUS
 Transformer Infinity TF700T

On Sun, Dec 12, 2021 at 12:13:55AM +0300, Dmitry Osipenko wrote:
[...]
> +		i2c@1 {
> +			reg = <1>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			dsi-bridge@7 {
> +				compatible = "toshiba,tc358768";
> +				reg = <0x7>;
> +
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				clocks = <&tc358768_osc>;
> +				clock-names = "refclk";
> +
> +				reset-gpios = <&gpio TEGRA_GPIO(N, 6) GPIO_ACTIVE_LOW>;
> +
> +				vddc-supply = <&vdd_1v2_mipi>;
> +				vddio-supply = <&vdd_1v8_vio>;
> +				vddmipi-supply = <&vdd_1v2_mipi>;
> +
> +				ports {
> +					#address-cells = <1>;
> +					#size-cells = <0>;
> +
> +					port@0 {
> +						reg = <0>;
> +
> +						bridge_input: endpoint {
> +							remote-endpoint = <&dpi_output>;
> +							data-lines = <24>;
> +						};
> +					};
> +
> +					port@1 {
> +						reg = <1>;
> +
> +						bridge_output: endpoint {
> +							remote-endpoint = <&panel_input>;
> +						};
> +					};
> +				};
> +
> +				/*
> +				 * Panasonic VVX10F004B00 or HYDIS HV101WU1-1E1
> +				 * LCD SuperIPS+ Full HD panel.
> +				 */
> +				panel@1 {
> +					compatible = "panasonic,vvx10f004b00";
> +					reg = <1>;
> +
> +					power-supply = <&vdd_pnl>;
> +					backlight = <&backlight>;
> +
> +					port {
> +						panel_input: endpoint {
> +							remote-endpoint = <&bridge_output>;
> +						};
> +					};
> +				};

make dtbs_check complains about this and says that panel@1 (as well as
#address-cells and #size-cells) are not allowed here. And indeed the
binding for the Toshiba bridge doesn't mention them here.

Do we need this here or should this be moved to the top level to fix
those warnings? I guess what you're doing above is describe a DSI bus
created by the DSI bridge, which also makes sense, so another
alternative would be to fix up the binding and let it accept those
properties.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)