linux-kernel - Re: [PATCH v6 15/28] ARM: tegra: Add usb-role-switch property to USB OTG ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9cf23721-db53-830a-f634-d2215232f059@gmail.com>
Date:   Wed, 15 Dec 2021 18:04:54 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Thierry Reding <thierry.reding@...il.com>
Cc:     Jonathan Hunter <jonathanh@...dia.com>,
        David Heidelberg <david@...t.cz>,
        Svyatoslav Ryhel <clamor95@...il.com>,
        Anton Bambura <jenneron@...tonmail.com>,
        Antoni Aloy Torrens <aaloytorrens@...il.com>,
        Nikola Milosavljevic <mnidza@...look.com>,
        Ion Agorria <ion@...rria.com>,
        Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        Ihor Didenko <tailormoon@...bler.ru>,
        Andreas Westman Dorcsak <hedmoo@...oo.com>,
        Maxim Schwalm <maxim.schwalm@...il.com>,
        Raffaele Tranquillini <raffaele.tranquillini@...il.com>,
        Jasper Korten <jja2000@...il.com>,
        Thomas Graichen <thomas.graichen@...il.com>,
        Stefan Eichenberger <stefan.eichenberger@...adex.com>,
        Stefan Agner <stefan@...er.ch>,
        Peter Geis <pgwipeout@...il.com>, devicetree@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 15/28] ARM: tegra: Add usb-role-switch property to USB
 OTG ports

15.12.2021 16:14, Thierry Reding пишет:
> On Sun, Dec 12, 2021 at 12:13:59AM +0300, Dmitry Osipenko wrote:
>> From: Stefan Eichenberger <stefan.eichenberger@...adex.com>
>>
>> If an USB port is an OTG port, then we should add the usb-role-switch
>> property. Otherwise XUSB setup fails and therefore padctl is unable to
>> set up the ports. This leads to broken USB and PCIe ports. Add the
>> usb-role-switch properties to Tegra124 device-trees to fix the problem.
>>
>> The error message shown without this patch is e.g:
>> usb2-0: usb-role-switch not found for otg mode
>>
>> [digetx@...il.com: improved commit message]
>> Tested-by: Thomas Graichen <thomas.graichen@...il.com> # T124 Nyan Big
>> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@...adex.com>
>> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
>> ---
>>  arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 1 +
>>  arch/arm/boot/dts/tegra124-apalis.dtsi      | 1 +
>>  arch/arm/boot/dts/tegra124-nyan.dtsi        | 1 +
>>  arch/arm/boot/dts/tegra124-venice2.dts      | 2 +-
>>  4 files changed, 4 insertions(+), 1 deletion(-)
> 
> The device tree bindings for the XUSB pad controller say that when this
> property is set, then the "connector" subnode should also exist.
> 
> Any chance we can add that? I was planning on making that a dependency
> in the json-schema conversion of the binding, in which case it would be
> more of a "must" than a "should".

I guess it will be harmless if you'll add the connector subnodes. Will
you be able to create a separate patch that will add the subnodes on top
of this patch?

Thomas Graichen says that one USB port on Nyan Big doesn't work without
this patch. This is why this patch is needed essentially.