linux-kernel - Re: [PATCH v4 2/2] misc: open-dice: Add driver to expose DICE data to userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YboHh6TJJ0VNHpV2@kroah.com>
Date:   Wed, 15 Dec 2021 16:19:35 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     David Brazdil <dbrazdil@...gle.com>
Cc:     Rob Herring <robh+dt@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Will Deacon <will@...nel.org>,
        Andrew Scull <ascull@...gle.com>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] misc: open-dice: Add driver to expose DICE data
 to userspace

On Wed, Dec 15, 2021 at 03:04:10PM +0000, David Brazdil wrote:
> +	drvdata = devm_kmalloc(dev, sizeof(*drvdata), GFP_KERNEL);
> +	if (!drvdata)
> +		return -ENOMEM;
> +
> +	*drvdata = (struct open_dice_drvdata){
> +		.lock = __SPIN_LOCK_UNLOCKED(drvdata->lock),
> +		.rmem = rmem,
> +		.misc = (struct miscdevice){
> +			.parent	= dev,
> +			.name	= drvdata->name,
> +			.minor	= MISC_DYNAMIC_MINOR,
> +			.fops	= &open_dice_fops,
> +			.mode	= 0600,
> +		},
> +	};

That is a lovely abuse of an implicit memcpy(), took me a while to
realize what it was doing here...

Anyway, this all looks great to me, I'll wait for the DT maintainers to
review the dt change before being able to take this through my tree.
Thanks for the cleanups based on the review, the driver is now almost
1/3 smaller than your first version with more functionality!

thanks,

greg k-h