linux-kernel - [asahilinux:touchpad/wip 80/82] drivers/hid/hid-appleft.c:68: warning: expecting prototype for struct magicmouse_sc. Prototype was for struct appleft

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 15 Dec 2021 23:46:02 +0800
From:   kernel test robot <lkp@...el.com>
To:     Janne Grunau <j@...nau.net>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Hector Martin <marcan@...can.st>
Subject: [asahilinux:touchpad/wip 80/82] drivers/hid/hid-appleft.c:68:
 warning: expecting prototype for struct magicmouse_sc. Prototype was for
 struct appleft_sc instead

tree:   https://github.com/AsahiLinux/linux touchpad/wip
head:   a2281d64fdbcbab0dae68c6ea75bd5b548332e06
commit: 23cee793a43b082dfa9c9a58a0fb9604c5825d7a [80/82] WIP: HID: Add hid-appleft for Apple Macbook Trackpads
config: nds32-allyesconfig (https://download.01.org/0day-ci/archive/20211215/202112152315.IFJ9Vy6H-lkp@intel.com/config)
compiler: nds32le-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/AsahiLinux/linux/commit/23cee793a43b082dfa9c9a58a0fb9604c5825d7a
        git remote add asahilinux https://github.com/AsahiLinux/linux
        git fetch --no-tags asahilinux touchpad/wip
        git checkout 23cee793a43b082dfa9c9a58a0fb9604c5825d7a
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nds32 SHELL=/bin/bash drivers/hid/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/hid/hid-appleft.c:68: warning: expecting prototype for struct magicmouse_sc. Prototype was for struct appleft_sc instead
   drivers/hid/hid-appleft.c:105: warning: Function parameter or member 'unknown_or_origin1' not described in 'tp_finger'
   drivers/hid/hid-appleft.c:105: warning: Function parameter or member 'unknown_or_origin2' not described in 'tp_finger'
>> drivers/hid/hid-appleft.c:127: warning: expecting prototype for struct trackpad. Prototype was for struct tp_header instead


vim +68 drivers/hid/hid-appleft.c

    43	
    44	/**
    45	 * struct magicmouse_sc - Tracks Magic Mouse-specific data.
    46	 * @input: Input device through which we report events.
    47	 * @quirks: Currently unused.
    48	 * @ntouches: Number of touches in most recent touch report.
    49	 * @scroll_accel: Number of consecutive scroll motions.
    50	 * @scroll_jiffies: Time of last scroll motion.
    51	 * @touches: Most recent data for a touch, indexed by tracking ID.
    52	 * @tracking_ids: Mapping of current touch input data to @touches.
    53	 */
    54	struct appleft_sc {
    55		struct input_dev *input;
    56		unsigned long quirks;
    57	
    58		int ntouches;
    59	
    60		struct input_mt_pos pos[MAX_CONTACTS];
    61		int slots[MAX_CONTACTS];
    62		u8 map_contacs[MAX_CONTACTS];
    63	
    64		struct hid_device *hdev;
    65		struct delayed_work work;
    66	
    67		int x_min, y_min, x_max, y_max;
  > 68	};
    69	
    70	/**
    71	 * struct tp_finger - single trackpad finger structure, le16-aligned
    72	 *
    73	 * @origin:		zero when switching track finger
    74	 * @abs_x:		absolute x coordinate
    75	 * @abs_y:		absolute y coordinate
    76	 * @rel_x:		relative x coordinate
    77	 * @rel_y:		relative y coordinate
    78	 * @tool_major:		tool area, major axis
    79	 * @tool_minor:		tool area, minor axis
    80	 * @orientation:	16384 when point, else 15 bit angle
    81	 * @touch_major:	touch area, major axis
    82	 * @touch_minor:	touch area, minor axis
    83	 * @unused:		zeros
    84	 * @pressure:		pressure on forcetouch touchpad
    85	 * @multi:		one finger: varies, more fingers: constant
    86	 * @crc16:		on last finger: crc over the whole message struct
    87	 *			(i.e. message header + this struct) minus the last
    88	 *			@crc16 field; unknown on all other fingers.
    89	 */
    90	struct tp_finger {
    91		__le16 unknown_or_origin1;
    92		__le16 unknown_or_origin2;
    93		__le16 abs_x;
    94		__le16 abs_y;
    95		__le16 rel_x;
    96		__le16 rel_y;
    97		__le16 tool_major;
    98		__le16 tool_minor;
    99		__le16 orientation;
   100		__le16 touch_major;
   101		__le16 touch_minor;
   102		__le16 unused[2];
   103		__le16 pressure;
   104		__le16 multi;
   105	} __attribute__((packed, aligned(2)));
   106	
   107	/**
   108	 * struct trackpad report
   109	 *
   110	 * @report_id:		reportid
   111	 * @buttons:		HID Usage Buttons 3 1-bit reports
   112	 * @num_fingers:	the number of fingers being reported in @fingers
   113	 * @clicked:		same as @buttons
   114	 */
   115	struct tp_header {
   116		// HID mouse report
   117		u8 report_id;
   118		u8 buttons;
   119		u8 rel_x;
   120		u8 rel_y;
   121		u8 padding[4];
   122		// HID vendor part, up to 1751 bytes
   123		u8 unknown[22];
   124		u8 num_fingers;
   125		u8 clicked;
   126		u8 unknown3[14];
 > 127	};
   128	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org