linux-kernel - Re: [PATCH] phy: freescale: pcie: explictly add bitfield.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 15 Dec 2021 20:51:39 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Hongxing Zhu <hongxing.zhu@....com>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] phy: freescale: pcie: explictly add bitfield.h

On 15-12-21, 06:29, Hongxing Zhu wrote:
> > -----Original Message-----
> > From: Vinod Koul <vkoul@...nel.org>
> > Sent: Wednesday, December 15, 2021 2:09 PM
> > To: Kishon Vijay Abraham I <kishon@...com>; Hongxing Zhu
> > <hongxing.zhu@....com>
> > Cc: linux-phy@...ts.infradead.org; Vinod Koul <vkoul@...nel.org>;
> > linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> > kernel test robot <lkp@...el.com>
> > Subject: [PATCH] phy: freescale: pcie: explictly add bitfield.h
> > 
> > kernel test robot complains about missing FIELD_PREP, so include
> > bitfield.h for that
> > 
> > drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit
> > declaration of function 'FIELD_PREP'
> > [-Werror=implicit-function-declaration]
> > drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:41: error: implicit
> > declaration of function 'FIELD_PREP'
> > [-Werror=implicit-function-declaration]
> > 
> > Reported-by: kernel test robot <lkp@...el.com>
> > Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie
> > standalone phy driver")
> > Signed-off-by: Vinod Koul <vkoul@...nel.org>
> Reviewed-by: Richard Zhu <hongxing.zhu@....com>

Thanks for quick review, I have pushed this

> Thanks a lot for your help to fix it.
> And I'm sorry about that I didn't capture this error in my local build and tests.

No worries, Do test on different arch's other than yours

-- 
~Vinod