linux-kernel - Re: [KVM] feb627e8d6: kernel-selftests.kvm.vmx_pmu_msrs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87czlxvozj.fsf@redhat.com>
Date:   Wed, 15 Dec 2021 16:58:56 +0100
From:   Vitaly Kuznetsov <vkuznets@...hat.com>
To:     kvm@...r.kernel.org, Paolo Bonzini <pbonzini@...hat.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, lkp@...ts.01.org,
        lkp@...el.com, xudong.hao@...el.com,
        kernel test robot <oliver.sang@...el.com>
Subject: Re: [KVM]  feb627e8d6: kernel-selftests.kvm.vmx_pmu_msrs_test.fail

kernel test robot <oliver.sang@...el.com> writes:

> Greeting,
>
> FYI, we noticed the following commit (built with gcc-9):
>
> commit: feb627e8d6f69c9a319fe279710959efb3eba873 ("KVM: x86: Forbid KVM_SET_CPUID{,2} after KVM_RUN")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
>

...

>
> # selftests: kvm: vmx_pmu_msrs_test
> # ==== Test Assertion Failure ====
> #   lib/x86_64/processor.c:874: rc == 0
> #   pid=10415 tid=10415 errno=22 - Invalid argument
> #      1	0x000000000040b24f: vcpu_set_cpuid at processor.c:873
> #      2	0x000000000040260a: main at vmx_pmu_msrs_test.c:115
> #      3	0x00007f07e1aec09a: ?? ??:0
> #      4	0x0000000000402759: _start at ??:?
> #   KVM_SET_CPUID2 failed, rc: -1 errno: 22
> not ok 33 selftests: kvm: vmx_pmu_msrs_test # exit=254
>

Hm, I'm pretty sure I've tested feb627e8d6f6 on both Intel and AMD and I
don't remember seeing this failure :-( . vmx_pmu_msrs_test test does
KVM_SET_CPUID after KVM_RUN and thus needs to be fixed too. Will send a
patch shortly.

-- 
Vitaly