Message-ID: <5c6c1f4d454d4ffc9501105ea7130660@emtrion.de>
Date:   Thu, 16 Dec 2021 16:56:54 +0000
From:   "Mueller, Reinhold" <Reinhold.Mueller@...rion.de>
To:     'Shawn Guo' <shawnguo@...nel.org>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "linux-imx@....com" <linux-imx@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        LinuxArmKernelMailingListe <linux-arm-kernel@...ts.infradead.org>
Subject: AW: [PATCH v2 2/2] arm64: dts: imx8mm: Add support for emtrion
 emCON-MX8M Mini

Hi Shawn,

many thanks for the feedback.
I corrected the marked issues, see the comments below.
I will send a new patchset.

Regards
Reinhold


Reinhold Mueller
Software engineer


emtrion GmbH
Am Hasenbiel 6 | 76297 Stutensee | Germany

Phone +49 7244 62694 20
Fax +49 7244 62694 19
Email Reinhold.Mueller@...rion.de
Online www.emtrion.de

*** Merry X-Mas & Happy New Year 2022 ***


emtrion GmbH • Amtsgericht Mannheim • HRB 110 300 • Geschäftsführer: Ramona Maurer, Achmed Haddou • Umsatzsteueridentifikationsnummer:DE813694260 • Impressum: www.emtrion.de/de/impressum.html

HINWEIS: Personenbezogene Daten, die Sie per E-Mail an uns übermitteln, werden bei uns gespeichert und verarbeitet. Informationen zu unseren gesetzlichen Informationspflichten, zu uns und unseren Dienstleistungen finden Sie in unseren Datenschutzhinweisen.
Diese E-Mail kann vertrauliche und / oder rechtlich geschützte Informationen enthalten. Wenn Sie nicht der richtige Adressat sind, oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte den Absender und vernichten diese Mail. Das unerlaubte kopieren, sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet.
> -----Ursprüngliche Nachricht-----
> Von: Shawn Guo <shawnguo@...nel.org>
> Gesendet: Donnerstag, 16. Dezember 2021 08:28
> An: Mueller, Reinhold <Reinhold.Mueller@...rion.de>
> Cc: robh+dt@...nel.org; s.hauer@...gutronix.de; kernel@...gutronix.de;
> festevam@...il.com; linux-imx@....com; devicetree@...r.kernel.org;
> linux-kernel@...r.kernel.org; LinuxArmKernelMailingListe <linux-arm-
> kernel@...ts.infradead.org>
> Betreff: Re: [PATCH v2 2/2] arm64: dts: imx8mm: Add support for emtrion
> emCON-MX8M Mini
>
> On Mon, Dec 13, 2021 at 02:29:09PM +0100, reinhold.mueller@...rion.com
> wrote:
> > From: Reinhold Mueller <reinhold.mueller@...rion.com>
> >
> > This patch adds support for the emtrion GmbH emCON-MX8M Mini
> modules.
> > They are available with NXP i.MX 8M Mini equipped with 2 or 4 GB
> Memory.
> >
> > The devicetree imx8mm-emcon.dtsi is the common part providing all
> > module components and the basic support for the SoC. The support for the
> > avari baseboard in the developer-kit configuration is provided by the
> > emcon-avari dts files.
> >
> > Signed-off-by: Reinhold Mueller <reinhold.mueller@...rion.com>
> > ---
> >  arch/arm64/boot/dts/freescale/Makefile        |   3 +-
> >  .../boot/dts/freescale/imx8mm-emcon-avari.dts |  23 +
> >  .../dts/freescale/imx8mm-emcon-avari.dtsi     | 141 ++++
> >  .../boot/dts/freescale/imx8mm-emcon.dtsi      | 645
> ++++++++++++++++++
> >  4 files changed, 811 insertions(+), 1 deletion(-)
> >  create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-emcon-
> avari.dts
> >  create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-emcon-
> avari.dtsi
> >  create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi
> >
> > diff --git a/arch/arm64/boot/dts/freescale/Makefile
> b/arch/arm64/boot/dts/freescale/Makefile
> > index a14a6173b765..a09b5e4d5a45 100644
> > --- a/arch/arm64/boot/dts/freescale/Makefile
> > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > @@ -34,8 +34,9 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-
> rdb.dtb
> >  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb
> >
> >  dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
> > -dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
> > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-emcon-avari.dtb
> > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-ctouch2.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx8mm-icore-mx8mm-edimm2.2.dtb
> >  dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-n801x-s.dtb
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dts
> b/arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dts
> > new file mode 100644
> > index 000000000000..b2e8967e9687
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dts
> > @@ -0,0 +1,23 @@
> > +// SPDX-License-Identifier: (GPL-2.0 or MIT)
> > +//
> > +// Copyright (c) 2021 emtrion GmbH
> > +// Author: Frank Erdrich <frank.erdrich@...rion.com>
> > +//
> > +
> > +/dts-v1/;
> > +
> > +#include "imx8mm-emcon.dtsi"
> > +#include "imx8mm-emcon-avari.dtsi"
> > +
> > +/ {
> > +model = "emtrion SoM emCON-MX8M mini on Avari";
> > +compatible = "emtrion,emcon-mx8mm-avari", "fsl,imx8mm";
> > +};
> > +
> > +&lvds_backlight {
> > +status = "okay";
> > +};
> > +
> > +&pwm1 {
> > +status = "okay";
> > +};
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtsi
> > new file mode 100644
> > index 000000000000..89fbf4b46f1b
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-emcon-avari.dtsi
> > @@ -0,0 +1,141 @@
> > +// SPDX-License-Identifier: (GPL-2.0 or MIT)
> > +//
> > +// Copyright (C) 2021 emtrion GmbH
> > +// Author: Frank Erdrich <frank.erdrich@...rion.com>
> > +//
> > +
> > +/ {
> > +aliases {
> > +boardid = &boardID;
> > +mmc0 = &usdhc1;
> > +mmc1 = &usdhc2;
> > +};
> > +
> > +chosen {
> > +stdout-path = &uart1;
> > +};
> > +
> > +reg_wall_5p0: reg-wall5p0 {
>
> Please spell out 'regulator-' in node name.
>
Have done it by the node names

> > +compatible = "regulator-fixed";
> > +regulator-name = "Main-Supply";
> > +regulator-min-microvolt = <5000000>;
> > +regulator-max-microvolt = <5000000>;
> > +regulator-always-on;
> > +regulator-boot-on;
> > +};
> > +
> > +reg_base3p3: reg-base3p3 {
> > +compatible = "regulator-fixed";
> > +vin-supply = <&reg_wall_5p0>;
> > +regulator-name = "3V3-avari";
> > +regulator-min-microvolt = <3300000>;
> > +regulator-max-microvolt = <3300000>;
> > +regulator-always-on;
> > +regulator-boot-on;
> > +};
> > +
> > +reg_base1p5: reg-base1p5 {
> > +compatible = "regulator-fixed";
> > +vin-supply = <&reg_base3p3>;
> > +regulator-name = "1V5-avari";
> > +regulator-min-microvolt = <1500000>;
> > +regulator-max-microvolt = <1500000>;
> > +regulator-always-on;
> > +regulator-boot-on;
> > +};
> > +
> > +reg_usb_otg: reg-otgvbus {
> > +compatible = "regulator-fixed";
> > +vin-supply = <&reg_wall_5p0>;
> > +regulator-name = "OTG_VBUS";
> > +regulator-min-microvolt = <5000000>;
> > +regulator-max-microvolt = <5000000>;
> > +gpio = <&gpio1 8 GPIO_ACTIVE_LOW>;
> > +regulator-always-on;
> > +};
> > +
> > +clk_codec: clock-codec {
> > +compatible = "fixed-clock";
> > +#clock-cells = <0>;
> > +clock-frequency = <12000000>;
> > +};
> > +
> > +sound {
> > +compatible = "simple-audio-card";
> > +simple-audio-card,name = "SGTL5000-Card";
> > +simple-audio-card,format = "i2s";
> > +simple-audio-card,bitclock-master = <&codec_dai>;
> > +simple-audio-card,frame-master = <&codec_dai>;
> > +simple-audio-card,widgets = "Headphone", "Headphone
> Jack";
> > +simple-audio-card,routing = "Headphone Jack", "HP_OUT";
> > +
> > +cpu_dai: simple-audio-card,cpu {
> > +sound-dai = <&sai2>;
> > +};
> > +
> > +codec_dai: simple-audio-card,codec {
> > +sound-dai = <&sgtl5000>;
> > +};
> > +};
> > +};
> > +
> > +&ecspi1 {
> > +status = "okay";
> > +};
> > +
> > +&i2c2 {
> > +status = "okay";
> > +};
> > +
> > +&i2c1 {
> > +clock-frequency = <100000>;
> > +status = "okay";
> > +
> > +sgtl5000: audio-codec@a {
> > +compatible = "fsl,sgtl5000";
> > +reg = <0x0a>;
> > +#sound-dai-cells = <0>;
> > +clocks = <&clk_codec>;
> > +VDDA-supply = <&reg_base3p3>;
> > +VDDIO-supply = <&reg_base3p3>;
> > +};
> > +
> > +boardID: gpio@3a {
> > +compatible = "nxp,pca8574";
> > +reg = <0x3a>;
> > +gpio-controller;
> > +#gpio-cells = <1>;
> > +};
> > +};
> > +
> > +&sai2 {
> > +status = "okay";
> > +};
> > +
> > +&uart2 {
> > +status = "okay";
>
> Please end property list with 'status'.
>
Changed it

> > +uart-has-rtscts;
> > +};
> > +
> > +&uart3 {
> > +status = "okay";
> > +};
> > +
> > +&uart4 {
> > +status = "okay";
> > +};
> > +
> > +&usbotg1 {
> > +status = "okay";
> > +};
> > +
> > +&usbotg2 {
> > +dr_mode = "host";
> > +status = "disabled";
> > +};
> > +
> > +&usdhc2 {
> > +status = "okay";
> > +};
> > +
> > +
>
> Drop EOF newlines.
Drpped the lines
>
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi
> > new file mode 100644
> > index 000000000000..54e1d3d8fa55
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-emcon.dtsi
> > @@ -0,0 +1,645 @@
> > +// SPDX-License-Identifier: (GPL-2.0 or MIT)
> > +//
> > +// Copyright 2018 NXP
> > +// Copyright (C) 2021 emtrion GmbH
> > +//
> > +
> > +/dts-v1/;
> > +
> > +#include "imx8mm.dtsi"
> > +
> > +/ {
> > +chosen {
> > +stdout-path = &uart1;
> > +};
> > +
> > +reserved-memory {
> > +#address-cells = <2>;
> > +#size-cells = <2>;
> > +ranges;
> > +
> > +rpmsg_reserved: rpmsg@...00000 {
> > +no-map;
> > +reg = <0 0xb8000000 0 0x400000>;
> > +};
> > +
> > +loader_reserved: loader@...00000 {
> > +no-map;
> > +reg = <0 0xbb700000 0x0 0x00100000>;
> > +};
> > +
> > +pci_reserved: pci@...00000 {
> > +no-map;
> > +reg = <0 0xbb800000 0x0 0x00200000>;
> > +};
> > +
> > +ivshmem2_reserved: ivshmem2@...00000 {
> > +no-map;
> > +reg = <0 0xbba00000 0x0 0x00100000>;
> > +};
> > +
> > +ivshmem_reserved: ivshmem@...00000 {
> > +no-map;
> > +reg = <0 0xbbb00000 0x0 0x00100000>;
> > +};
> > +};
> > +
> > +som_leds: leds {
> > +compatible = "gpio-leds";
> > +pinctrl-names = "default";
> > +pinctrl-0 = <&pinctrl_gpio_led>;
> > +
> > +green {
> > +label = "som:green";
> > +gpios = <&gpio3 4 GPIO_ACTIVE_HIGH>;
> > +default-state = "on";
> > +linux,default-trigger = "heartbeat";
> > +};
> > +
> > +red {
> > +label = "som:red";
> > +gpios = <&gpio5 10 GPIO_ACTIVE_HIGH>;
> > +default-state = "off";
> > +};
> > +};
> > +
> > +lvds_backlight: lvds-backlight {
> > +compatible = "pwm-backlight";
> > +enable-gpios = <&gpio3 23 GPIO_ACTIVE_HIGH>;
> > +pwms = <&pwm1 0 50000 0>;
> > +brightness-levels = <
> > +0 4 8 16 32 64 80 96 112
> > +128 144 160 176 250
> > +>;
> > +default-brightness-level = <9>;
> > +status = "disabled";
> > +};
> > +
> > +reg_usdhc1_vmmc: regulator-emmc {
> > +compatible = "regulator-fixed";
> > +regulator-name = "eMMC";
> > +regulator-min-microvolt = <3300000>;
> > +regulator-max-microvolt = <3300000>;
> > +};
> > +
> > +reg_usdhc2_vmmc: regulator-usdhc2 {
> > +compatible = "regulator-fixed";
> > +regulator-name = "sdcard_3V3";
> > +regulator-min-microvolt = <3300000>;
> > +regulator-max-microvolt = <3300000>;
> > +};
> > +};
> > +
> > +&A53_0 {
> > +cpu-supply = <&buck2_reg>;
> > +};
> > +
> > +&ecspi1 {
> > +pinctrl-names = "default";
> > +pinctrl-0 = <&pinctrl_ecspi1 &pinctrl_ecspi1_cs>;
> > +cs-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>;
> > +status = "okay";
> > +};
> > +
> > +&flexspi {
> > +pinctrl-names = "default";
> > +pinctrl-0 = <&pinctrl_flexspi0>;
> > +pinctrl-1 = <&pinctrl_flexspi1>;
> > +status = "okay";
> > +
> > +flash0: spi-flash@0 {
> > +reg = <0>;
> > +#address-cells = <1>;
> > +#size-cells = <1>;
> > +compatible = "jedec,spi-nor";
> > +spi-max-frequency = <40000000>;
> > +};
> > +};
> > +
> > +&iomuxc {
> > +pinctrl-names = "default";
> > +
> > +pinctrl_csi_pwn: csi_pwn_grp {
>
> Hyphen is more recommended for node name.
>
Inserted hyphen in some more node names
> > +fsl,pins = <
> > +MX8MM_IOMUXC_GPIO1_IO07_GPIO1_IO7
> 0x19
> > +>;
> > +};
> > +
> > +pinctrl_ecspi1: ecspi1grp {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_ECSPI1_SCLK_ECSPI1_SCLK
> 0x82
> > +MX8MM_IOMUXC_ECSPI1_MOSI_ECSPI1_MOSI
> 0x82
> > +MX8MM_IOMUXC_ECSPI1_MISO_ECSPI1_MISO
> 0x82
> > +>;
> > +};
> > +
> > +pinctrl_ecspi1_cs: ecspi1cs {
>
> Name the pinctrl node more consistently.
>
I did it
> > +fsl,pins = <
> > +MX8MM_IOMUXC_ECSPI1_SS0_GPIO5_IO9
> 0x40000
> > +MX8MM_IOMUXC_ECSPI2_SS0_GPIO5_IO13
> 0x40000
> > +>;
> > +};
> > +
> > +pinctrl_fec1: fec1grp {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_ENET_MDC_ENET1_MDC
> 0x3
> > +MX8MM_IOMUXC_ENET_MDIO_ENET1_MDIO
> 0x3
> > +MX8MM_IOMUXC_ENET_TD3_ENET1_RGMII_TD3
> 0x1f
> > +MX8MM_IOMUXC_ENET_TD2_ENET1_RGMII_TD2
> 0x1f
> > +MX8MM_IOMUXC_ENET_TD1_ENET1_RGMII_TD1
> 0x1f
> > +MX8MM_IOMUXC_ENET_TD0_ENET1_RGMII_TD0
> 0x1f
> > +MX8MM_IOMUXC_ENET_RD3_ENET1_RGMII_RD3
> 0x91
> > +MX8MM_IOMUXC_ENET_RD2_ENET1_RGMII_RD2
> 0x91
> > +MX8MM_IOMUXC_ENET_RD1_ENET1_RGMII_RD1
> 0x91
> > +MX8MM_IOMUXC_ENET_RD0_ENET1_RGMII_RD0
> 0x91
> > +MX8MM_IOMUXC_ENET_TXC_ENET1_RGMII_TXC
> 0x1f
> > +MX8MM_IOMUXC_ENET_RXC_ENET1_RGMII_RXC
> 0x91
> > +
> MX8MM_IOMUXC_ENET_RX_CTL_ENET1_RGMII_RX_CTL0x91
> > +
> MX8MM_IOMUXC_ENET_TX_CTL_ENET1_RGMII_TX_CTL0x1f
> > +MX8MM_IOMUXC_GPIO1_IO09_GPIO1_IO9
> 0x19
> > +>;
> > +};
> > +
> > +pinctrl_flexspi0: flexspi0grp {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_NAND_ALE_QSPI_A_SCLK
> 0x1c2
> > +MX8MM_IOMUXC_NAND_CE0_B_QSPI_A_SS0_B
> 0x82
> > +MX8MM_IOMUXC_NAND_DATA00_QSPI_A_DATA0
> 0x82
> > +MX8MM_IOMUXC_NAND_DATA01_QSPI_A_DATA1
> 0x82
> > +MX8MM_IOMUXC_NAND_DATA02_QSPI_A_DATA2
> 0x82
> > +MX8MM_IOMUXC_NAND_DATA03_QSPI_A_DATA3
> 0x82
> > +MX8MM_IOMUXC_NAND_DQS_QSPI_A_DQS
> 0x82
> > +>;
> > +};
> > +
> > +pinctrl_flexspi1: flexspi1grp {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_NAND_CLE_QSPI_B_SCLK
> 0x1c2
> > +MX8MM_IOMUXC_NAND_CE2_B_QSPI_B_SS0_B
> 0x82
> > +MX8MM_IOMUXC_NAND_DATA04_QSPI_B_DATA0
> 0x82
> > +MX8MM_IOMUXC_NAND_DATA05_QSPI_B_DATA1
> 0x82
> > +MX8MM_IOMUXC_NAND_DATA06_QSPI_B_DATA2
> 0x82
> > +MX8MM_IOMUXC_NAND_DATA07_QSPI_B_DATA3
> 0x82
> > +>;
> > +};
> > +
> > +pinctrl_gpio_led: gpioledgrp {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_ECSPI2_SCLK_GPIO5_IO10
> 0x19
> > +MX8MM_IOMUXC_NAND_CE3_B_GPIO3_IO4
> 0x19
> > +>;
> > +};
> > +
> > +pinctrl_i2c1: i2c1grp {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_I2C1_SCL_I2C1_SCL
> 0x400001c3
> > +MX8MM_IOMUXC_I2C1_SDA_I2C1_SDA
> 0x400001c3
> > +>;
> > +};
> > +
> > +pinctrl_i2c2: i2c2grp {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_I2C2_SCL_I2C2_SCL
> 0x400001c3
> > +MX8MM_IOMUXC_I2C2_SDA_I2C2_SDA
> 0x400001c3
> > +>;
> > +};
> > +
> > +pinctrl_i2c3: i2c3grp {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_I2C3_SCL_I2C3_SCL
> 0x400001c3
> > +MX8MM_IOMUXC_I2C3_SDA_I2C3_SDA
> 0x400001c3
> > +>;
> > +};
> > +
> > +pinctrl_lvds: lvdsgrp {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_SAI5_MCLK_GPIO3_IO25
> 0x06
> > +>;
> > +};
> > +
> > +pinctrl_pcie0: pcie0grp {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_SAI5_RXC_GPIO3_IO20
> 0x41
> > +MX8MM_IOMUXC_SAI5_RXFS_GPIO3_IO19
> 0x41
> > +>;
> > +};
> > +
> > +pinctrl_pmic: pmicirq {
>
> Ditto
>
I did it
> > +fsl,pins = <
> > +MX8MM_IOMUXC_NAND_CE1_B_GPIO3_IO2
> 0x41
> > +>;
> > +};
> > +
> > +pinctrl_pwm1: pwm1grp {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_GPIO1_IO01_PWM1_OUT
> 0x06
> > +>;
> > +};
> > +
> > +pinctrl_sai2: sai2grp {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_SAI2_MCLK_SAI2_MCLK
> 0xd6
> > +MX8MM_IOMUXC_SAI2_RXC_SAI2_RX_BCLK
> 0xd6
> > +MX8MM_IOMUXC_SAI2_RXD0_SAI2_RX_DATA0
> 0xd6
> > +MX8MM_IOMUXC_SAI2_RXFS_SAI2_RX_SYNC
> 0xd6
> > +MX8MM_IOMUXC_SAI2_TXC_SAI2_TX_BCLK
> 0xd6
> > +MX8MM_IOMUXC_SAI2_TXD0_SAI2_TX_DATA0
> 0xd6
> > +MX8MM_IOMUXC_SAI2_TXFS_SAI2_TX_SYNC
> 0xd6
> > +>;
> > +};
> > +
> > +pinctrl_spdif1: spdif1grp {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_SPDIF_TX_SPDIF1_OUT
> 0xd6
> > +MX8MM_IOMUXC_SPDIF_RX_SPDIF1_IN
> 0xd6
> > +>;
> > +};
> > +
> > +pinctrl_uart1: uart1grp {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_UART1_RXD_UART1_DCE_RX
> 0x140
> > +MX8MM_IOMUXC_UART1_TXD_UART1_DCE_TX
> 0x140
> > +>;
> > +};
> > +
> > +pinctrl_uart2: uart2grp {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_UART2_RXD_UART2_DCE_RX
> 0x140
> > +MX8MM_IOMUXC_UART2_TXD_UART2_DCE_TX
> 0x140
> > +
> > +/* rts and cts */
> > +MX8MM_IOMUXC_SAI3_RXC_UART2_DCE_CTS_B
> 0x140
> > +MX8MM_IOMUXC_SAI3_RXD_UART2_DCE_RTS_B
> 0x140
> > +>;
> > +};
> > +
> > +pinctrl_uart3: uart3grp {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_UART3_RXD_UART3_DCE_RX
> 0x140
> > +MX8MM_IOMUXC_UART3_TXD_UART3_DCE_TX
> 0x140
> > +>;
> > +};
> > +
> > +pinctrl_uart4: uart4grp {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_UART4_RXD_UART4_DCE_RX
> 0x140
> > +MX8MM_IOMUXC_UART4_TXD_UART4_DCE_TX
> 0x140
> > +>;
> > +};
> > +
> > +pinctrl_usdhc1_gpio: usdhc1grpgpio {
>
> End with 'grp' maybe.
>
> > +fsl,pins = <
> > +MX8MM_IOMUXC_SD1_RESET_B_USDHC1_RESET_B
> 0x41
> > +MX8MM_IOMUXC_GPIO1_IO03_GPIO1_IO3
> 0x1c4
> > +>;
> > +};
> > +
> > +pinctrl_usdhc1: usdhc1grp {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK
> 0x190
> > +MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD
> 0x1d0
> > +MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0
> 0x1d0
> > +MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1
> 0x1d0
> > +MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2
> 0x1d0
> > +MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3
> 0x1d0
> > +MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4
> 0x1d0
> > +MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5
> 0x1d0
> > +MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6
> 0x1d0
> > +MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7
> 0x1d0
> > +>;
> > +};
> > +
> > +pinctrl_usdhc1_100mhz: usdhc1grp100mhz {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK
> 0x194
> > +MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD
> 0x1d4
> > +MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0
> 0x1d4
> > +MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1
> 0x1d4
> > +MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2
> 0x1d4
> > +MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3
> 0x1d4
> > +MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4
> 0x1d4
> > +MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5
> 0x1d4
> > +MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6
> 0x1d4
> > +MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7
> 0x1d4
> > +>;
> > +};
> > +
> > +pinctrl_usdhc1_200mhz: usdhc1grp200mhz {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_SD1_CLK_USDHC1_CLK
> 0x196
> > +MX8MM_IOMUXC_SD1_CMD_USDHC1_CMD
> 0x1d6
> > +MX8MM_IOMUXC_SD1_DATA0_USDHC1_DATA0
> 0x1d6
> > +MX8MM_IOMUXC_SD1_DATA1_USDHC1_DATA1
> 0x1d6
> > +MX8MM_IOMUXC_SD1_DATA2_USDHC1_DATA2
> 0x1d6
> > +MX8MM_IOMUXC_SD1_DATA3_USDHC1_DATA3
> 0x1d6
> > +MX8MM_IOMUXC_SD1_DATA4_USDHC1_DATA4
> 0x1d6
> > +MX8MM_IOMUXC_SD1_DATA5_USDHC1_DATA5
> 0x1d6
> > +MX8MM_IOMUXC_SD1_DATA6_USDHC1_DATA6
> 0x1d6
> > +MX8MM_IOMUXC_SD1_DATA7_USDHC1_DATA7
> 0x1d6
> > +>;
> > +};
> > +
> > +/* no reset for sdhc2 interface */
> > +pinctrl_usdhc2_gpio: usdhc2grpgpio {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_SD2_CD_B_GPIO2_IO12
> 0x1c4
> > +MX8MM_IOMUXC_SD2_WP_USDHC2_WP
> 0x1c4
> > +>;
> > +};
> > +
> > +pinctrl_usdhc2: usdhc2grp {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK
> 0x190
> > +MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD
> 0x1d0
> > +MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0
> 0x1d0
> > +MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1
> 0x1d0
> > +MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2
> 0x1d0
> > +MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3
> 0x1d0
> > +MX8MM_IOMUXC_GPIO1_IO04_USDHC2_VSELECT
> 0x1d0
> > +>;
> > +};
> > +
> > +pinctrl_usdhc2_100mhz: usdhc2grp100mhz {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK
> 0x194
> > +MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD
> 0x1d4
> > +MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0
> 0x1d4
> > +MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1
> 0x1d4
> > +MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2
> 0x1d4
> > +MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3
> 0x1d4
> > +MX8MM_IOMUXC_GPIO1_IO04_USDHC2_VSELECT
> 0x1d0
> > +>;
> > +};
> > +
> > +pinctrl_usdhc2_200mhz: usdhc2grp200mhz {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_SD2_CLK_USDHC2_CLK
> 0x196
> > +MX8MM_IOMUXC_SD2_CMD_USDHC2_CMD
> 0x1d6
> > +MX8MM_IOMUXC_SD2_DATA0_USDHC2_DATA0
> 0x1d6
> > +MX8MM_IOMUXC_SD2_DATA1_USDHC2_DATA1
> 0x1d6
> > +MX8MM_IOMUXC_SD2_DATA2_USDHC2_DATA2
> 0x1d6
> > +MX8MM_IOMUXC_SD2_DATA3_USDHC2_DATA3
> 0x1d6
> > +MX8MM_IOMUXC_GPIO1_IO04_USDHC2_VSELECT
> 0x1d0
> > +>;
> > +};
> > +
> > +pinctrl_wdog: wdoggrp {
> > +fsl,pins = <
> > +MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B
> 0xc6
> > +>;
> > +};
> > +};
> > +
> > +&i2c1 {
> > +clock-frequency = <400000>;
> > +pinctrl-names = "default";
> > +pinctrl-0 = <&pinctrl_i2c1>;
> > +status = "okay";
> > +};
> > +
> > +&i2c2 {
> > +clock-frequency = <400000>;
> > +pinctrl-names = "default";
> > +pinctrl-0 = <&pinctrl_i2c2>;
> > +status = "okay";
> > +};
> > +
> > +&i2c3 {
> > +clock-frequency = <400000>;
> > +pinctrl-names = "default";
> > +pinctrl-0 = <&pinctrl_i2c3>;
> > +status = "okay";
> > +
> > +bd71847:pmic@4b {
>
> Missing space before node name.
>
Ok, have inserted
> > +compatible = "rohm,bd71847";
> > +reg = <0x4b>;
> > +pinctrl-0 = <&pinctrl_pmic>;
> > +interrupt-parent = <&gpio3>;
> > +interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> > +rohm,reset-snvs-powered;
> > +
> > +regulators {
> > +buck1_reg: BUCK1 {
> > +regulator-name = "BUCK1";
> > +regulator-min-microvolt = <700000>;
> > +regulator-max-microvolt = <1300000>;
> > +regulator-boot-on;
> > +regulator-always-on;
> > +regulator-ramp-delay = <1250>;
> > +};
> > +
> > +buck2_reg: BUCK2 {
> > +regulator-name = "BUCK2";
> > +regulator-min-microvolt = <700000>;
> > +regulator-max-microvolt = <1300000>;
> > +regulator-boot-on;
> > +regulator-always-on;
> > +regulator-ramp-delay = <1250>;
> > +rohm,dvs-run-voltage = <1000000>;
> > +rohm,dvs-idle-voltage = <900000>;
> > +};
> > +
> > +buck3_reg: BUCK3 {
> > +// BUCK5 in datasheet
> > +regulator-name = "BUCK3";
> > +regulator-min-microvolt = <700000>;
> > +regulator-max-microvolt = <1350000>;
> > +regulator-boot-on;
> > +regulator-always-on;
> > +};
> > +
> > +buck4_reg: BUCK4 {
> > +// BUCK6 in datasheet
> > +regulator-name = "BUCK4";
> > +regulator-min-microvolt = <3000000>;
> > +regulator-max-microvolt = <3300000>;
> > +regulator-boot-on;
> > +regulator-always-on;
> > +};
> > +
> > +buck5_reg: BUCK5 {
> > +// BUCK7 in datasheet
> > +regulator-name = "BUCK5";
> > +regulator-min-microvolt = <1605000>;
> > +regulator-max-microvolt = <1995000>;
> > +regulator-boot-on;
> > +regulator-always-on;
> > +};
> > +
> > +buck6_reg: BUCK6 {
> > +// BUCK8 in datasheet
> > +regulator-name = "BUCK6";
> > +regulator-min-microvolt = <800000>;
> > +regulator-max-microvolt = <1400000>;
> > +regulator-boot-on;
> > +regulator-always-on;
> > +};
> > +
> > +ldo1_reg: LDO1 {
> > +regulator-name = "LDO1";
> > +regulator-min-microvolt = <1600000>;
> > +regulator-max-microvolt = <1900000>;
> > +regulator-boot-on;
> > +regulator-always-on;
> > +};
> > +
> > +ldo2_reg: LDO2 {
> > +regulator-name = "LDO2";
> > +regulator-min-microvolt = <800000>;
> > +regulator-max-microvolt = <900000>;
> > +regulator-boot-on;
> > +regulator-always-on;
> > +};
> > +
> > +ldo3_reg: LDO3 {
> > +regulator-name = "LDO3";
> > +regulator-min-microvolt = <1800000>;
> > +regulator-max-microvolt = <3300000>;
> > +regulator-boot-on;
> > +regulator-always-on;
> > +};
> > +
> > +ldo4_reg: LDO4 {
> > +regulator-name = "LDO4";
> > +regulator-min-microvolt = <900000>;
> > +regulator-max-microvolt = <1800000>;
> > +regulator-boot-on;
> > +regulator-always-on;
> > +};
> > +
> > +ldo6_reg: LDO6 {
> > +regulator-name = "LDO6";
> > +regulator-min-microvolt = <900000>;
> > +regulator-max-microvolt = <1800000>;
> > +regulator-boot-on;
> > +regulator-always-on;
> > +};
> > +};
> > +};
> > +
> > +rv1805:rtc@69 {
>
> Ditto
>
Ok, i did it, too
> > +reg = <0x69>;
> > +compatible = "abracon,ab1805";
>
> Flip the order to start properties with compatible.
>
Ok, i ordered it
> > +};
> > +};
> > +
> > +&mu {
> > +status = "okay";
> > +};
> > +
> > +&pwm1 {
> > +pinctrl-names = "default";
> > +pinctrl-0 = <&pinctrl_pwm1>;
> > +};
> > +
> > +&sai2 {
> > +#sound-dai-cells = <0>;
> > +pinctrl-names = "default";
> > +pinctrl-0 = <&pinctrl_sai2>;
> > +assigned-clocks = <&clk IMX8MM_CLK_SAI2>;
> > +assigned-clock-parents = <&clk IMX8MM_AUDIO_PLL1_OUT>;
> > +assigned-clock-rates = <12000000>;
> > +status = "disabled";
> > +};
> > +
> > +&spdif1 {
> > +pinctrl-names = "default";
> > +pinctrl-0 = <&pinctrl_spdif1>;
> > +assigned-clocks = <&clk IMX8MM_CLK_SPDIF1>;
> > +assigned-clock-parents = <&clk IMX8MM_AUDIO_PLL1_OUT>;
> > +assigned-clock-rates = <24576000>;
> > +clocks = <&clk IMX8MM_CLK_AUDIO_AHB>, <&clk
> IMX8MM_CLK_24M>,
> > +<&clk IMX8MM_CLK_SPDIF1>, <&clk
> IMX8MM_CLK_DUMMY>,
> > +<&clk IMX8MM_CLK_DUMMY>, <&clk
> IMX8MM_CLK_DUMMY>,
> > +<&clk IMX8MM_CLK_AUDIO_AHB>, <&clk
> IMX8MM_CLK_DUMMY>,
> > +<&clk IMX8MM_CLK_DUMMY>, <&clk
> IMX8MM_CLK_DUMMY>,
> > +<&clk IMX8MM_AUDIO_PLL1_OUT>, <&clk
> IMX8MM_AUDIO_PLL2_OUT>;
> > +clock-names = "core", "rxtx0", "rxtx1", "rxtx2", "rxtx3",
> > +"rxtx4", "rxtx5", "rxtx6", "rxtx7", "spba", "pll8k", "pll11k";
> > +status = "disabled";
> > +};
> > +
> > +&fec1 {
>
> Sort label node alphabetically.
>
Ok, moved it
> Shawn
>
> > +pinctrl-names = "default";
> > +pinctrl-0 = <&pinctrl_fec1>;
> > +phy-mode = "rgmii-id";
> > +phy-reset-gpios = <&gpio1 9 0>;
> > +fsl,magic-packet;
> > +status = "okay";
> > +};
> > +
> > +&uart1 { /* console */
> > +pinctrl-names = "default";
> > +pinctrl-0 = <&pinctrl_uart1>;
> > +assigned-clocks = <&clk IMX8MM_CLK_UART1>;
> > +assigned-clock-parents = <&clk IMX8MM_SYS_PLL1_80M>;
> > +status = "okay";
> > +};
> > +
> > +&uart2 {
> > +pinctrl-names = "default";
> > +pinctrl-0 = <&pinctrl_uart2>;
> > +assigned-clocks = <&clk IMX8MM_CLK_UART2>;
> > +assigned-clock-parents = <&clk IMX8MM_SYS_PLL1_80M>;
> > +status = "okay";
> > +};
> > +
> > +&uart3 {
> > +pinctrl-names = "default";
> > +pinctrl-0 = <&pinctrl_uart3>;
> > +assigned-clocks = <&clk IMX8MM_CLK_UART3>;
> > +assigned-clock-parents = <&clk IMX8MM_SYS_PLL1_80M>;
> > +status = "okay";
> > +};
> > +
> > +&uart4 {
> > +pinctrl-names = "default";
> > +pinctrl-0 = <&pinctrl_uart4>;
> > +assigned-clocks = <&clk IMX8MM_CLK_UART4>;
> > +assigned-clock-parents = <&clk IMX8MM_SYS_PLL1_80M>;
> > +status = "okay";
> > +};
> > +
> > +&usbotg1 {
> > +dr_mode = "otg";
> > +over-current-active-low;
> > +status = "okay";
> > +};
> > +
> > +&usbotg2 {
> > +dr_mode = "host";
> > +disable-over-current;
> > +status = "disabled";
> > +};
> > +
> > +&usdhc1 {
> > +pinctrl-names = "default", "state_100mhz", "state_200mhz";
> > +pinctrl-0 = <&pinctrl_usdhc1>, <&pinctrl_usdhc1_gpio>;
> > +pinctrl-1 = <&pinctrl_usdhc1_100mhz>, <&pinctrl_usdhc1_gpio>;
> > +pinctrl-2 = <&pinctrl_usdhc1_200mhz>, <&pinctrl_usdhc1_gpio>;
> > +bus-width = <8>;
> > +vmmc-supply = <&reg_usdhc1_vmmc>;
> > +keep-power-in-suspend;
> > +non-removable;
> > +status = "okay";
> > +};
> > +
> > +&usdhc2 {
> > +pinctrl-names = "default", "state_100mhz", "state_200mhz";
> > +pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
> > +pinctrl-1 = <&pinctrl_usdhc2_100mhz>, <&pinctrl_usdhc2_gpio>;
> > +pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_gpio>;
> > +cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>;
> > +wp-gpios = <&gpio2 20 GPIO_ACTIVE_HIGH>;
> > +bus-width = <4>;
> > +vmmc-supply = <&reg_usdhc2_vmmc>;
> > +no-1-8-v;
> > +status = "okay";
> > +};
> > +
> > +&wdog1 {
> > +pinctrl-names = "default";
> > +pinctrl-0 = <&pinctrl_wdog>;
> > +fsl,ext-reset-output;
> > +status = "okay";
> > +};
> > --
> > 2.20.1
> >

Powered by blists - more mailing lists