linux-kernel - Re: [PATCH 2/2] dt-bindings: usb: document snps,dis_split

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YbufNsBtiIzbm+9k@robh.at.kernel.org>
Date:   Thu, 16 Dec 2021 14:19:02 -0600
From:   Rob Herring <robh@...nel.org>
To:     Sergey Shtylyov <s.shtylyov@....ru>, Yaqin Pan <akingchen@...o.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Felipe Balbi <balbi@...nel.org>, linux-usb@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...o.com
Subject: Re: [PATCH 2/2] dt-bindings: usb: document snps,dis_split_quirk
 property in dwc3

On Thu, Dec 16, 2021 at 06:59:27PM +0300, Sergey Shtylyov wrote:
> On 12/16/21 11:26 AM, Sergey Shtylyov wrote:
> 
> >> Add snps,dis_split_quirk property for dwc3 controller
> >>
> >> Signed-off-by: Yaqin Pan <akingchen@...o.com>
> >> ---
> >>   Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 6 ++++++
> >>   1 file changed, 6 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> >> index 41416fbd92aa..e9615ca8f447 100644
> >> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> >> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> >> @@ -226,6 +226,12 @@ properties:
> >>         avoid -EPROTO errors with usbhid on some devices (Hikey 970).
> >>       type: boolean
> >>   +  snps,dis_split_quirk:

I'm tired of the never ending DWC3 quirks. Imply this from the 
compatible unless it varies by board.

Also, don't use '_' in DT names.

> >> +    description:
> >> +      When set, change the way host controller schedules transations for a Control transfer.
> > 
> >    Transactions.
> > 
> >> +      Needed to avoid emurate some devices fail.
> > 
> >    Avoid failing to enumerating some devices?
> 
>    Sorry. enumarate. :-)

Or enumerate