linux-kernel - Re: [PATCH v3 2/8] dt-bindings: phy: phy-rockchip-inno-usb2: add rk3568 documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YbuiHfUPezvB01CH@robh.at.kernel.org>
Date:   Thu, 16 Dec 2021 14:31:25 -0600
From:   Rob Herring <robh@...nel.org>
To:     Peter Geis <pgwipeout@...il.com>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Johan Jonker <jbx6244@...il.com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-phy@...ts.infradead.org, Heiko Stuebner <heiko@...ech.de>,
        Vinod Koul <vkoul@...nel.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v3 2/8] dt-bindings: phy: phy-rockchip-inno-usb2: add
 rk3568 documentation

On Wed, 15 Dec 2021 16:02:46 -0500, Peter Geis wrote:
> The rk3568 usb2phy node is a standalone node with a single muxed
> interrupt.
> Add documentation for it to phy-rockchip-inno-usb2.
> 
> Signed-off-by: Peter Geis <pgwipeout@...il.com>
> ---
> 
> This was the best solution I've come up with for this.
> I avoided creating another binding since this is such a simple change to
> the actual driver and would likely require renaming the existing
> binding.
> I've tested that this correctly flags if the interrupts are missing or
> incorrectly assigned on both rk356x and rk3399.
> 
> Thank you Johan and Rob for your constructive feedback.
> 
>  .../bindings/phy/phy-rockchip-inno-usb2.yaml  | 44 +++++++++++++++++--
>  1 file changed, 40 insertions(+), 4 deletions(-)
> 

Reviewed-by: Rob Herring <robh@...nel.org>