linux-kernel - Re: [PATCH v3 0/5] rtc: nintendo: Add a RTC driver for the GameCube, Wii and Wii U

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211216205836.yporkr4omon4mdd2@luna>
Date:   Thu, 16 Dec 2021 21:58:36 +0100
From:   Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     Emmanuel Gil Peyrot <linkmauve@...kmauve.fr>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Jonathan Neuschäfer <j.ne@...teo.net>,
        linux-rtc@...r.kernel.org, Michael Ellerman <mpe@...erman.id.au>,
        Rob Herring <robh+dt@...nel.org>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        linuxppc-dev@...ts.ozlabs.org, Ash Logan <ash@...quark.com>,
        rw-r-r-0644 <r.r.qwertyuiop.r.r@...il.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Paul Mackerras <paulus@...ba.org>
Subject: Re: [PATCH v3 0/5] rtc: nintendo: Add a RTC driver for the GameCube,
 Wii and Wii U

On Thu, Dec 16, 2021 at 09:56:06PM +0100, Alexandre Belloni wrote:
> On 16/12/2021 21:22:20+0100, Emmanuel Gil Peyrot wrote:
> > On Thu, Dec 16, 2021 at 10:49:44AM +0100, Alexandre Belloni wrote:
> > > On Wed, 15 Dec 2021 18:54:56 +0100, Emmanuel Gil Peyrot wrote:
> > > > These three consoles share a device, the MX23L4005, which contains a
> > > > clock and 64 bytes of SRAM storage, and is exposed on the EXI bus
> > > > (similar to SPI) on channel 0, device 1.  This driver allows it to be
> > > > used as a Linux RTC device, where time can be read and set.
> > > > 
> > > > The hardware also exposes two timers, one which shuts down the console
> > > > and one which powers it on, but these aren’t supported currently.
> > > > 
> > > > [...]
> > > 
> > > Applied, thanks!
> > > 
> > > [1/5] rtc: gamecube: Add a RTC driver for the GameCube, Wii and Wii U
> > >       commit: 86559400b3ef9de93ba50523cffe767c35cd531a
> > > [2/5] rtc: gamecube: Report low battery as invalid data
> > >       commit: 322539a014bcd24cbb9281832c09b24e07912237
> > > [3/5] powerpc: wii.dts: Expose HW_SRNPROT on this platform
> > >       commit: 5479618e1e2641dd57352a73b7b7b2f6908fbeee
> > > [4/5] powerpc: gamecube_defconfig: Enable the RTC driver
> > >       commit: 57bd7d356506b713d0df8d8e42da7810a18864df
> > > [5/5] powerpc: wii_defconfig: Enable the RTC driver
> > >       commit: 69e8ba80ddda4db31e59facbf2db19773ad3785b
> > > 
> > > This one didn't apply ceanly but I believe I did the right thing. Can you check?
> > 
> > I believe you didn’t, at least that commit[1] seems to have one “+” too
> > many in the modified line, whereas the previous one[2] doesn’t.
> > 
> 
> I knew I needed you to check, this is fixed now.
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?id=c636783d594f6cfc95db51c796761719317ce5eb

Perfect, thanks a lot!

> 
> 
> -- 
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

-- 
Emmanuel Gil Peyrot

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)