lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 16 Dec 2021 09:09:32 +0800 From: Leo Yan <leo.yan@...aro.org> To: Richard Guy Briggs <rgb@...hat.com> Cc: Paul Moore <paul@...l-moore.com>, codalist@...emann.coda.cs.cmu.edu, Jan Harkes <jaharkes@...cmu.edu>, Leon Romanovsky <leon@...nel.org>, Mathieu Poirier <mathieu.poirier@...aro.org>, Suzuki K Poulose <suzuki.poulose@....com>, Alexander Shishkin <alexander.shishkin@...ux.intel.com>, netdev@...r.kernel.org, Balbir Singh <bsingharora@...il.com>, linux-kernel@...r.kernel.org, Eric Paris <eparis@...hat.com>, coda@...cmu.edu, linux-audit@...hat.com, coresight@...ts.linaro.org, Jakub Kicinski <kuba@...nel.org>, "David S. Miller" <davem@...emloft.net>, linux-arm-kernel@...ts.infradead.org, Mike Leach <mike.leach@...aro.org> Subject: Re: [PATCH v2 6/7] audit: Use task_is_in_init_pid_ns() On Wed, Dec 15, 2021 at 02:09:12PM -0500, Richard Guy Briggs wrote: > On 2021-12-14 17:35, Paul Moore wrote: > > On Wed, Dec 8, 2021 at 3:33 AM Leo Yan <leo.yan@...aro.org> wrote: > > > > > > Replace open code with task_is_in_init_pid_ns() for checking root PID > > > namespace. > > > > > > Signed-off-by: Leo Yan <leo.yan@...aro.org> > > > --- > > > kernel/audit.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > I'm not sure how necessary this is, but it looks correct to me. > > I had the same thought. I looks correct to me. I could see the value > if it permitted init_pid_ns to not be global. Just for a background info, we need to check root PID namespace in some drivers [1], to avoid introducing more open codes, we decided to refactor with helper task_is_in_init_pid_ns(). [1] https://lore.kernel.org/lkml/20211213121323.1887180-1-leo.yan@linaro.org/ > > Acked-by: Paul Moore <paul@...l-moore.com> > > Reviewed-by: Richard Guy Briggs <rgb@...hat.com> Thanks for review, Paul and Richard. Leo
Powered by blists - more mailing lists