linux-kernel - RE: [PATCH v6 08/10] irqchip: Add Sunplus SP7021 interrupt controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e150f340a98b49a2b6958bc0f0530214@cqplus1.com>
Date:   Thu, 16 Dec 2021 10:06:27 +0000
From:   qinjian[覃健] <qinjian@...lus1.com>
To:     Marc Zyngier <maz@...nel.org>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mturquette@...libre.com" <mturquette@...libre.com>,
        "sboyd@...nel.org" <sboyd@...nel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "stefan.wahren@...e.com" <stefan.wahren@...e.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        Wells Lu 呂芳騰 <wells.lu@...plus.com>
Subject: RE: [PATCH v6 08/10] irqchip: Add Sunplus SP7021 interrupt controller
 driver

> From: Marc Zyngier <maz@...nel.org>
> Sent: Thursday, December 16, 2021 4:52 PM
> To: qinjian[覃健] <qinjian@...lus1.com>
> Cc: robh+dt@...nel.org; mturquette@...libre.com; sboyd@...nel.org; tglx@...utronix.de; p.zabel@...gutronix.de;
> linux@...linux.org.uk; broonie@...nel.org; arnd@...db.de; stefan.wahren@...e.com; linux-arm-kernel@...ts.infradead.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; linux-clk@...r.kernel.org; Wells Lu 呂芳騰 <wells.lu@...plus.com>
> Subject: Re: [PATCH v6 08/10] irqchip: Add Sunplus SP7021 interrupt controller driver
> 
> On Thu, 16 Dec 2021 07:08:10 +0000,
> Qin Jian <qinjian@...lus1.com> wrote:
> >
> > Add interrupt controller driver for Sunplus SP7021 SoC.
> >
> > This is the interrupt controller in P-chip which collects all interrupt
> > sources in P-chip and routes them to parent interrupt controller in C-chip.
> >
> > Signed-off-by: Qin Jian <qinjian@...lus1.com>
> > ---
> > Fix the comments from Marc.
> 
> No, you didn't.
> 
> > +void sp_intc_set_ext(u32 hwirq, int ext_num)
> > +{
> > +	sp_intc_assign_bit(hwirq, REG_INTR_PRIORITY, !ext_num);
> > +}
> > +EXPORT_SYMBOL_GPL(sp_intc_set_ext);
> 
> I already commented on this. In case it wasn't clear, this is a strong
> NAK to random low-level hacks like this.
> 

Yes, I just forgot delete this.
Sorry for my mistake, I'll fix it on next commit.