linux-kernel - Re: [PATCH 0/2] Fix RGB status LED and keyboard backlight LEDs on Nokia N900

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fb433210-e0e7-908c-eb0d-e4e58691368a@wizzup.org>
Date:   Thu, 16 Dec 2021 12:51:28 +0100
From:   Merlijn Wajer <merlijn@...zup.org>
To:     Pavel Machek <pavel@....cz>
Cc:     Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
        Dev Null <devnull@...s.xyz>, Tony Lindgren <tony@...mide.com>,
        Sebastian Reichel <sre@...nel.org>,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
        linux-omap@...r.kernel.org, Dan Murphy <dmurphy@...com>,
        devicetree@...r.kernel.org, Doug Zobel <dougdev334@...il.com>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        "Sicelo A . Mhlongo" <absicsz@...il.com>,
        Benoît Cousson <bcousson@...libre.com>
Subject: Re: [PATCH 0/2] Fix RGB status LED and keyboard backlight LEDs on
 Nokia N900

Hi Pavel,

On 15/12/2021 21:32, Pavel Machek wrote:
> Hi!
> 
>> The RGB status LED and keyboard backlight LEDs were broken on the Nokia N900
>> since the conversion to gpiod descriptors and additionally later on with the
>> addition of multi color support. There was at least one attempt merged to fix
>> the lp5523 driver since the gpiod conversion, but it doesn't honour the device
>> tree, which in the case of the Nokia N900 means that the fix doesn't work.
>>
>> In this series are two patches fix the problems:
>>
>> * One addresses the gpiod change in the device tree as well as the multi
>>   color support in the device tree;
>> * The other patch fixes the previous attempt at fixing the driver to honour
>>   the device tree;
>>
>> Please let me know if anything seems off, and I'll be glad to make any
>> recommended changes, thanks!
> 
> Thank you, I took the series. But if it changes the names in
> /sys/class/leds, we want to do something else.

Thanks -- just for the record (I already replied to the other email) -
the names do not change based on my testing.

Regards,
Merlijn