linux-kernel - Re: [PATCH v2] ksmbd: disable SMB2_GLOBAL_CAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKYAXd9w7BBGBn_ZuSNZ-KVL_YLUW0_TFAKXSRr=YAdETsMv6A@mail.gmail.com>
Date:   Thu, 16 Dec 2021 20:53:04 +0900
From:   Namjae Jeon <linkinjeon@...nel.org>
To:     Marcos Del Sol Vives <marcos@...a.pet>
Cc:     linux-cifs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ksmbd: disable SMB2_GLOBAL_CAP_ENCRYPTION for SMB 3.1.1

2021-12-16 19:37 GMT+09:00, Marcos Del Sol Vives <marcos@...a.pet>:
> According to the official Microsoft MS-SMB2 document section 3.3.5.4, this
> flag should be used only for 3.0 and 3.0.2 dialects. Setting it for 3.1.1
> is a violation of the specification.
>
> This causes my Windows 10 client to detect an anomaly in the negotiation,
> and disable encryption entirely despite being explicitly enabled in ksmbd,
> causing all data transfers to go in plain text.
>
> Signed-off-by: Marcos Del Sol Vives <marcos@...a.pet>
> Cc: linux-kernel@...r.kernel.org
> Cc: Namjae Jeon <linkinjeon@...nel.org>
Acked-by: Namjae Jeon <linkinjeon@...nel.org>

Thanks!