linux-kernel - Re: [PATCH iio-next] drivers/iio: remove redundant ret variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Dec 2021 12:31:36 +0000
From:   Jonathan Cameron <jic23@...23.retrosnub.co.uk>
To:     cgel.zte@...il.com
Cc:     lars@...afoo.de, chi.minghao@....com.cn, nuno.sa@...log.com,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH iio-next] drivers/iio: remove redundant ret variable

On Wed, 15 Dec 2021 06:07:10 +0000
cgel.zte@...il.com wrote:

> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Return value from ads8688_prog_write() directly instead
> of taking this in another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>

applied,

Thanks,

> ---
>  drivers/iio/adc/ti-ads8688.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/ti-ads8688.c b/drivers/iio/adc/ti-ads8688.c
> index 79c803537dc4..2e24717d7f55 100644
> --- a/drivers/iio/adc/ti-ads8688.c
> +++ b/drivers/iio/adc/ti-ads8688.c
> @@ -281,12 +281,10 @@ static int ads8688_write_reg_range(struct iio_dev *indio_dev,
>  				   enum ads8688_range range)
>  {
>  	unsigned int tmp;
> -	int ret;
>  
>  	tmp = ADS8688_PROG_REG_RANGE_CH(chan->channel);
> -	ret = ads8688_prog_write(indio_dev, tmp, range);
>  
> -	return ret;
> +	return ads8688_prog_write(indio_dev, tmp, range);
>  }
>  
>  static int ads8688_write_raw(struct iio_dev *indio_dev,