linux-kernel - Re: [PATCH v16 29/40] soc/tegra: fuse: Use resource-managed helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ybs4S4WMJBhAEWWp@orome>
Date:   Thu, 16 Dec 2021 13:59:55 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Jonathan Hunter <jonathanh@...dia.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Viresh Kumar <vireshk@...nel.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Peter De Schrijver <pdeschrijver@...dia.com>,
        Mikko Perttunen <mperttunen@...dia.com>,
        Lee Jones <lee.jones@...aro.org>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, Nishanth Menon <nm@...com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Michael Turquette <mturquette@...libre.com>,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-pm@...r.kernel.org, linux-pwm@...r.kernel.org,
        linux-mmc@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-clk@...r.kernel.org, David Heidelberg <david@...t.cz>
Subject: Re: [PATCH v16 29/40] soc/tegra: fuse: Use resource-managed helpers

On Wed, Dec 01, 2021 at 02:23:36AM +0300, Dmitry Osipenko wrote:
> Use resource-managed helpers to make code cleaner and more correct,
> properly releasing all resources in case of driver probe error.
> 
> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> ---
>  drivers/soc/tegra/fuse/fuse-tegra.c   | 32 ++++++++++++++------------
>  drivers/soc/tegra/fuse/fuse-tegra20.c | 33 ++++++++++++++++++++++++---
>  2 files changed, 48 insertions(+), 17 deletions(-)

Ehm... this is very borderline. Adding 31 lines of code isn't exactly
making the code cleaner.

On the other hand I don't care enough to get into an argument, so I've
applied this anyway.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)