linux-kernel - Re: [PATCH 1/2] sizes.h: Add SZ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b32bd540-ca84-8de4-00b8-500a8cfdaf79@csgroup.eu>
Date:   Thu, 16 Dec 2021 14:23:53 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Krzysztof Wilczyński <kw@...ux.com>
CC:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        Toan Le <toan@...amperecomputing.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: Re: [PATCH 1/2] sizes.h: Add SZ_1T macro



Le 08/12/2021 à 22:19, Krzysztof Wilczyński a écrit :
> Hello Christophe,
> 
>> Today drivers/pci/controller/pci-xgene.c defines SZ_1T
>>
>> Move it into linux/sizes.h so that it can be re-used elsewhere.
> 
> Sounds like a good idea!
> 
> By the way, there was an earlier version of this patch, did something
> happened?  I think you simply extracted these changes from the other
> series, correct?


Yes it was previously in series 
https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=274229&state=*

I decided to put it aside in a new separate series 
https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=275829&state=* 
because the change in patch 2 is independant.

> 
>> diff --git a/drivers/pci/controller/pci-xgene.c b/drivers/pci/controller/pci-xgene.c
>> index 56d0d50338c8..716dcab5ca47 100644
>> --- a/drivers/pci/controller/pci-xgene.c
>> +++ b/drivers/pci/controller/pci-xgene.c
>> @@ -49,7 +49,6 @@
>>   #define EN_REG				0x00000001
>>   #define OB_LO_IO			0x00000002
>>   #define XGENE_PCIE_DEVICEID		0xE004
>> -#define SZ_1T				(SZ_1G*1024ULL)
>>   #define PIPE_PHY_RATE_RD(src)		((0xc000 & (u32)(src)) >> 0xe)
>>   
>>   #define XGENE_V1_PCI_EXP_CAP		0x40
>> diff --git a/include/linux/sizes.h b/include/linux/sizes.h
>> index 1ac79bcee2bb..84aa448d8bb3 100644
>> --- a/include/linux/sizes.h
>> +++ b/include/linux/sizes.h
>> @@ -47,6 +47,8 @@
>>   #define SZ_8G				_AC(0x200000000, ULL)
>>   #define SZ_16G				_AC(0x400000000, ULL)
>>   #define SZ_32G				_AC(0x800000000, ULL)
>> +
>> +#define SZ_1T				_AC(0x10000000000, ULL)
>>   #define SZ_64T				_AC(0x400000000000, ULL)
>>   
>>   #endif /* __LINUX_SIZES_H__ */
> 
> Thank you!
> 
> Reviewed-by: Krzysztof Wilczyński <kw@...ux.com>

Thanks

Christophe