linux-kernel - Re: [PATCH v4 20/20] extcon: intel-cht-wc: Report RID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <827d2fe4-e50c-ce4c-9e6c-e10555bbabef@samsung.com>
Date:   Thu, 16 Dec 2021 11:55:19 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     Hans de Goede <hdegoede@...hat.com>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Mark Gross <markgross@...nel.org>,
        Andy Shevchenko <andy@...radead.org>,
        Wolfram Sang <wsa@...-dreams.de>,
        Lee Jones <lee.jones@...aro.org>,
        Sebastian Reichel <sre@...nel.org>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Ard Biesheuvel <ardb@...nel.org>
Cc:     Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
        Yauhen Kharuzhy <jekhor@...il.com>,
        Tsuchiya Yuto <kitakar@...il.com>,
        platform-driver-x86@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-efi@...r.kernel.org
Subject: Re: [PATCH v4 20/20] extcon: intel-cht-wc: Report RID_A for ACA
 adapters

On 12/6/21 6:33 PM, Hans de Goede wrote:
> Make cht_wc_extcon_get_id() report RID_A for ACA adapters, instead of
> reporting ID_FLOAT.
> 
> According to the spec. we should read the USB-ID pin ADC value
> to determine the resistance of the used pull-down resister and
> then return RID_A / RID_B / RID_C based on this. But all "Accessory
> Charger Adapter"s (ACAs) which users can actually buy always use
> a combination of a charging port with one or more USB-A ports, so
> they should always use a resistor indicating RID_A. But the spec
> is hard to read / badly-worded so some of them actually indicate
> they are a RID_B ACA even though they clearly are a RID_A ACA.
> 
> To workaround this simply always return INTEL_USB_RID_A, which
> matches all the ACAs which users can actually buy.
> 
> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
> ---
>  drivers/extcon/extcon-intel-cht-wc.c | 18 +++++++++++++-----
>  1 file changed, 13 insertions(+), 5 deletions(-)
[snip]

Acked-by: Chanwoo Choi <cw00.choi@...sung.com>

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics