linux-kernel - Re: [PATCH V8 02/10] irqchip/loongson-pch-pic: Add ACPI init support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pmpwwpw5.wl-maz@kernel.org>
Date:   Thu, 16 Dec 2021 15:06:18 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Huacai Chen <chenhuacai@...ngson.cn>
Cc:     Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
        Xuefeng Li <lixuefeng@...ngson.cn>,
        Huacai Chen <chenhuacai@...il.com>,
        Jiaxun Yang <jiaxun.yang@...goat.com>
Subject: Re: [PATCH V8 02/10] irqchip/loongson-pch-pic: Add ACPI init support

On Thu, 16 Dec 2021 12:53:48 +0000,
Huacai Chen <chenhuacai@...ngson.cn> wrote:
> 
> We are preparing to add new Loongson (based on LoongArch, not compatible
> with old MIPS-based Loongson) support. LoongArch use ACPI other than DT
> as its boot protocol, so add ACPI init support.
> 
> PCH-PIC/PCH-MSI stands for "Interrupt Controller" that described in
> Section 5 of "Loongson 7A1000 Bridge User Manual". For more information
> please refer Documentation/loongarch/irq-chip-model.rst.
> 
> Signed-off-by: Huacai Chen <chenhuacai@...ngson.cn>
> ---
>  drivers/irqchip/irq-loongson-pch-pic.c | 108 ++++++++++++++++++-------
>  1 file changed, 81 insertions(+), 27 deletions(-)

[...]

>
> +#ifdef CONFIG_ACPI
> +
> +struct irq_domain *pch_pic_acpi_init(struct irq_domain *parent,
> +					struct acpi_madt_bio_pic *acpi_pchpic)

Who is calling this? This works the opposite way from what the arm64
irqchips are doing. Why? I have the ugly feeling that this is called
from the arch code, bypassing the existing infrastructure...

	M.

-- 
Without deviation from the norm, progress is not possible.