linux-kernel - Re: [PATCH v3 1/2] dt-bindings: firmware: Add Open Profile for DICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Dec 2021 09:21:00 -0600
From:   Rob Herring <robh@...nel.org>
To:     David Brazdil <dbrazdil@...gle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>, Will Deacon <will@...nel.org>,
        Andrew Scull <ascull@...gle.com>, devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: firmware: Add Open Profile for DICE

On Wed, Dec 15, 2021 at 3:08 PM David Brazdil <dbrazdil@...gle.com> wrote:
>
> Hi Rob,
>
> > > +        dice_reserved: dice@...40000 {
> > > +            reg = <0x00 0x12340000 0x2000>;
> > > +            no-map;
> > > +        };
> > > +    };
> > > +
> > > +    dice {
> > > +        compatible = "google,open-dice";
> > > +        memory-region = <&dice_reserved>;
> >
> > There's no need for this indirection. Just add the compatible to the
> > dice@...40000 node. You can bind drivers to /reserved-memory nodes.
>
> I have not found a way to make that work for kernel modules. Built-in
> drivers can bind with RESERVEDMEM_OF_DECLARE, which puts an entry in
> __reservedmem_of_table and __reserved_mem_init_node() iterates find it
> there. A good case study might be CONFIG_TEGRA210_EMC, where the driver
> itself can be a module but the rmem parsing is always built-in under
> CONFIG_TEGRA210_EMC_TABLE. I don't think that's worth the trouble with
> this driver.

I forgot you have to add the compatible to reserved_mem_matches in
drivers/of/platform.c.

Rob