linux-kernel - Re: [PATCH v1] dt-bindings: sound: tegra-audio-rt5677: Correct example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df97dc4f-175f-738b-1670-303113dd58c7@gmail.com>
Date:   Thu, 16 Dec 2021 19:07:19 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Mark Brown <broonie@...nel.org>,
        David Heidelberg <david@...t.cz>,
        Rob Herring <robh+dt@...nel.org>
Cc:     linux-tegra@...r.kernel.org, devicetree@...r.kernel.org,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] dt-bindings: sound: tegra-audio-rt5677: Correct
 example

16.12.2021 19:02, Dmitry Osipenko пишет:
> Remove non-existent properties from the example of the binding. These
> properties were borrower from the old txt binding, but they were never
> used in practice and aren't documented in the new binding. They aren't
> reported by the binding checker because dtschema needs extra patch that
> hasn't been upstreamed yet to make unevaluatedProperties work properly.
> 
> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> ---
>  .../devicetree/bindings/sound/nvidia,tegra-audio-rt5677.yaml   | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5677.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5677.yaml
> index 03ff691c26c8..a49997d6028b 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5677.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra-audio-rt5677.yaml
> @@ -92,9 +92,6 @@ examples:
>          nvidia,audio-codec = <&rt5677>;
>  
>          nvidia,hp-det-gpios = <&gpio 143 0>;
> -        nvidia,mic-present-gpios = <&gpio 132 1>;
> -        nvidia,hp-en-gpios = <&rt5677 1 0>;
> -        nvidia,dmic-clk-en-gpios = <&rt5677 2 1>;
>  
>          clocks = <&clk 216>,
>                   <&clk 217>,
> 

Interestingly, I can't find any Tegra device-tree that uses this rt5677
binding. Maybe we should remove it?