linux-kernel - Re: [PATCH] usb: uhci: Use platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Ybtk4qqN2NYQSZKP@rowland.harvard.edu>
Date:   Thu, 16 Dec 2021 11:10:10 -0500
From:   Alan Stern <stern@...land.harvard.edu>
To:     Rob Herring <robh@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        linux-arm-kernel@...ts.infradead.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: uhci: Use platform_get_irq() to get the interrupt

On Wed, Dec 15, 2021 at 04:52:03PM -0600, Rob Herring wrote:
> Accessing platform device resources directly has long been deprecated for
> DT as IRQ resources may not be available at device creation time. Drivers
> continuing to use static IRQ resources is blocking removing the static setup
> from the DT core code.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---

Acked-by: Alan Stern <stern@...land.harvard.edu>

>  drivers/usb/host/uhci-platform.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/uhci-platform.c b/drivers/usb/host/uhci-platform.c
> index 70dbd95c3f06..b854699e9e4e 100644
> --- a/drivers/usb/host/uhci-platform.c
> +++ b/drivers/usb/host/uhci-platform.c
> @@ -132,7 +132,11 @@ static int uhci_hcd_platform_probe(struct platform_device *pdev)
>  		goto err_rmr;
>  	}
>  
> -	ret = usb_add_hcd(hcd, pdev->resource[1].start, IRQF_SHARED);
> +	ret = platform_get_irq(pdev, 0);
> +	if (ret < 0)
> +		goto err_clk;
> +
> +	ret = usb_add_hcd(hcd, ret, IRQF_SHARED);
>  	if (ret)
>  		goto err_clk;
>  
> -- 
> 2.32.0
>