linux-kernel - Re: [PATCH] usb: ohci-spear: Remove direct access to platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YbtlBaUqlLtNR+/c@rowland.harvard.edu>
Date:   Thu, 16 Dec 2021 11:10:45 -0500
From:   Alan Stern <stern@...land.harvard.edu>
To:     Rob Herring <robh@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: ohci-spear: Remove direct access to platform_device
 resource list

On Wed, Dec 15, 2021 at 04:55:09PM -0600, Rob Herring wrote:
> The memory resource is already retrieved with platform_get_resource(), so
> let's use it instead of assuming it is the first resource in the array.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---

Acked-by: Alan Stern <stern@...land.harvard.edu>

>  drivers/usb/host/ohci-spear.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ohci-spear.c b/drivers/usb/host/ohci-spear.c
> index b4cd9e6c72fd..9b81f420656d 100644
> --- a/drivers/usb/host/ohci-spear.c
> +++ b/drivers/usb/host/ohci-spear.c
> @@ -76,7 +76,7 @@ static int spear_ohci_hcd_drv_probe(struct platform_device *pdev)
>  		goto err_put_hcd;
>  	}
>  
> -	hcd->rsrc_start = pdev->resource[0].start;
> +	hcd->rsrc_start = res->start;
>  	hcd->rsrc_len = resource_size(res);
>  
>  	sohci_p = to_spear_ohci(hcd);
> -- 
> 2.32.0
>