linux-kernel - Re: [PATCH v5 2/5] drivers: acpi: acpi_apd: Remove unused device property "is-rv"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 17 Dec 2021 19:23:57 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     "Limonciello, Mario" <Mario.Limonciello@....com>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        "Pandey, Ajit Kumar" <AjitKumar.Pandey@....com>,
        Stephen Boyd <sboyd@...nel.org>,
        linux-clk <linux-clk@...r.kernel.org>,
        "Mukunda, Vijendar" <Vijendar.Mukunda@....com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Hiregoudar, Basavaraj" <Basavaraj.Hiregoudar@....com>,
        "Dommati, Sunil-kumar" <Sunil-kumar.Dommati@....com>,
        Len Brown <lenb@...nel.org>,
        "open list:ACPI" <linux-acpi@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 2/5] drivers: acpi: acpi_apd: Remove unused device
 property "is-rv"

On Fri, Dec 17, 2021 at 7:19 PM Limonciello, Mario
<Mario.Limonciello@....com> wrote:
>
> [Public]
>
> > -----Original Message-----
> > From: Rafael J. Wysocki <rafael@...nel.org>
> > Sent: Friday, December 17, 2021 12:07
> > To: Pandey, Ajit Kumar <AjitKumar.Pandey@....com>
> > Cc: Stephen Boyd <sboyd@...nel.org>; linux-clk <linux-clk@...r.kernel.org>;
> > Mukunda, Vijendar <Vijendar.Mukunda@....com>; Deucher, Alexander
> > <Alexander.Deucher@....com>; Hiregoudar, Basavaraj
> > <Basavaraj.Hiregoudar@....com>; Dommati, Sunil-kumar <Sunil-
> > kumar.Dommati@....com>; Limonciello, Mario
> > <Mario.Limonciello@....com>; Rafael J. Wysocki <rafael@...nel.org>; Len
> > Brown <lenb@...nel.org>; open list:ACPI <linux-acpi@...r.kernel.org>; open
> > list <linux-kernel@...r.kernel.org>
> > Subject: Re: [PATCH v5 2/5] drivers: acpi: acpi_apd: Remove unused device
> > property "is-rv"
> >
> > On Sun, Dec 12, 2021 at 7:06 PM Ajit Kumar Pandey
> > <AjitKumar.Pandey@....com> wrote:
> > >
> > > Initially "is-rv" device property is added for 48MHz fixed clock
> > > support on Raven or RV architecture. It's unused now as we moved
> > > to pci device_id based selection to extend such support on other
> > > architectures. This change removed unused code from acpi driver.
> > >
> > > Signed-off-by: Ajit Kumar Pandey <AjitKumar.Pandey@....com>
> > > Reviewed-by: Mario Limonciello <Mario.Limonciello@....com>
> >
> > Does this or the next patch depend on the rest of the series, or can I
> > simply apply them both?
>
> There are (intentional) dependencies within this series on the order.  It
> would be better for the whole series to come through one tree.

So please route these two along with the rest of the series and I
don't think you need my ACKs for this.

>
> >
> > > ---
> > >  drivers/acpi/acpi_apd.c               | 3 ---
> > >  include/linux/platform_data/clk-fch.h | 1 -
> > >  2 files changed, 4 deletions(-)
> > >
> > > diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c
> > > index 6e02448d15d9..6913e9712852 100644
> > > --- a/drivers/acpi/acpi_apd.c
> > > +++ b/drivers/acpi/acpi_apd.c
> > > @@ -87,9 +87,6 @@ static int fch_misc_setup(struct apd_private_data
> > *pdata)
> > >         if (ret < 0)
> > >                 return -ENOENT;
> > >
> > > -       if (!acpi_dev_get_property(adev, "is-rv", ACPI_TYPE_INTEGER, &obj))
> > > -               clk_data->is_rv = obj->integer.value;
> > > -
> > >         list_for_each_entry(rentry, &resource_list, node) {
> > >                 clk_data->base = devm_ioremap(&adev->dev, rentry->res->start,
> > >                                               resource_size(rentry->res));
> > > diff --git a/include/linux/platform_data/clk-fch.h
> > b/include/linux/platform_data/clk-fch.h
> > > index b9f682459f08..850ca776156d 100644
> > > --- a/include/linux/platform_data/clk-fch.h
> > > +++ b/include/linux/platform_data/clk-fch.h
> > > @@ -12,7 +12,6 @@
> > >
> > >  struct fch_clk_data {
> > >         void __iomem *base;
> > > -       u32 is_rv;
> > >  };
> > >
> > >  #endif /* __CLK_FCH_H */
> > > --
> > > 2.25.1
> > >