linux-kernel - Re: [PATCH] powerpc/mpic: Use bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d0ffcb0f-459c-95c6-a3d2-da39a7d87873@wanadoo.fr>
Date:   Fri, 17 Dec 2021 22:50:54 +0100
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     vneethv@...ux.ibm.com, oberpar@...ux.ibm.com, hca@...ux.ibm.com,
        gor@...ux.ibm.com, borntraeger@...ux.ibm.com,
        agordeev@...ux.ibm.com
Cc:     linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] powerpc/mpic: Use bitmap_zalloc() when applicable

Le 17/12/2021 à 22:37, Christophe JAILLET a écrit :
> 'mpic->protected' is a bitmap. So use 'bitmap_zalloc()' to simplify
> code and improve the semantic, instead of hand writing it.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>   drivers/s390/cio/idset.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/s390/cio/idset.c b/drivers/s390/cio/idset.c
> index 45f9c0736be4..7e5550230c0f 100644
> --- a/drivers/s390/cio/idset.c
> +++ b/drivers/s390/cio/idset.c
> @@ -25,11 +25,10 @@ static struct idset *idset_new(int num_ssid, int num_id)
>   {
>   	struct idset *set;
>   
> -	set = vmalloc(sizeof(struct idset) + bitmap_size(num_ssid, num_id));
> +	set = vzalloc(sizeof(struct idset) + bitmap_size(num_ssid, num_id));
>   	if (set) {
>   		set->num_ssid = num_ssid;
>   		set->num_id = num_id;
> -		memset(set->bitmap, 0, bitmap_size(num_ssid, num_id));
>   	}
>   	return set;
>   }
> 
NACK,

my git GUI played me some tricks.
Wrong patch attached :(

CJ