linux-kernel - Re: linux-next: Tree for Dec 17 (drivers/reset/reset-starfive-jh7100.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 17 Dec 2021 22:53:26 +0100
From:   Emil Renner Berthing <kernel@...il.dk>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Arnd Bergmann <arnd@...nel.org>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>
Subject: Re: linux-next: Tree for Dec 17 (drivers/reset/reset-starfive-jh7100.c)

Hi Randy,

On Fri, 17 Dec 2021 at 22:48, Randy Dunlap <rdunlap@...radead.org> wrote:
> On 12/17/21 05:33, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20211216:
> >
>
> on i386:
>
> ../drivers/reset/reset-starfive-jh7100.c: In function ‘jh7100_reset_update’:
> ../drivers/reset/reset-starfive-jh7100.c:81:10: error: implicit declaration of function ‘readq’; did you mean ‘readl’? [-Werror=implicit-function-declaration]
>   value = readq(reg_assert);
>           ^~~~~
> ../drivers/reset/reset-starfive-jh7100.c:86:2: error: implicit declaration of function ‘writeq’; did you mean ‘writel’? [-Werror=implicit-function-declaration]
>   writeq(value, reg_assert);
>   ^~~~~~

Yes, It needs to include <linux/io-64-nonatomic-lo-hi.h> for compile
testing to work on 32bit architectures without readq.

Arnd: Do I just send a patch or do I redo the pull-request?

/Emil