linux-kernel - Re: [PATCH] Header line: Coding style fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211217233408.GA47062@animalcreek.com>
Date:   Fri, 17 Dec 2021 16:34:08 -0700
From:   Mark Greer <mgreer@...malcreek.com>
To:     Jorge Eduardo Fermino Oliveia Silva <jorge.ubermensch@...il.com>
Cc:     mgreer@...malcreek.com, greybus-dev@...ts.linaro.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Header line: Coding style fix

On Fri, Dec 17, 2021 at 11:34:08AM -0300, Jorge Eduardo Fermino Oliveia Silva wrote:

[Note: I am traveling for the next week so I won't be very responsive.]

Hi Jorge.

Before we get to the platch please remember that you should send all
Greybus patches to greybus-dev@...ts.linaro.org and
linux-kernel@...r.kernel.org.  I will add them in now and leave all of
the context so other can see what you sent.

> Solve CHECK: Lines should not end with a '('
> 
> Reported-by: Jorge Eduardo Fermino Oliveia Silva <jorgeubermensch@...il.com>
> Signed-off-by: Jorge Eduardo Fermino Oliveia Silva <jorgeubermensch@...il.com>
> ---
>  drivers/staging/greybus/audio_manager_private.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/greybus/audio_manager_private.h b/drivers/staging/greybus/audio_manager_private.h
> index 2b3a766c7de7..a17f09a19014 100644
> --- a/drivers/staging/greybus/audio_manager_private.h
> +++ b/drivers/staging/greybus/audio_manager_private.h
> @@ -12,10 +12,10 @@
>  
>  #include "audio_manager.h"
>  
> -int gb_audio_manager_module_create(
> -	struct gb_audio_manager_module **module,
> -	struct kset *manager_kset,
> -	int id, struct gb_audio_manager_module_descriptor *desc);
> +int gb_audio_manager_module_create(struct gb_audio_manager_module **module,
> +				   struct kset *manager_kset,
> +				   int id,
> +			struct gb_audio_manager_module_descriptor *desc);
>  
>  /* module destroyed via kobject_put */

The part you're removing has all of the parameters at the same
indentation level and what you adding has them at two different
indentation levels so I'm not sure this is a step forward.  Since the
kernel coding style doesn't address this specific case, AFAICS, I would
leave it as is despite the complaint.  If others disagree then go ahead
as I really don't care much either way.

Mark
--