linux-kernel - Re: [security] d3b04a4398: WARNING:at_crypto/kdf_sp800108.c:#crypto_kdf108

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211217041403.GA19847@gondor.apana.org.au>
Date:   Fri, 17 Dec 2021 15:14:03 +1100
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Stephan Mueller <smueller@...onox.de>
Cc:     Yujie Liu <yujie.liu@...el.com>,
        Mat Martineau <mathew.j.martineau@...ux.intel.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        lkp@...ts.01.org, lkp@...el.com,
        "Sang, Oliver" <oliver.sang@...el.com>
Subject: Re: [security] d3b04a4398:
 WARNING:at_crypto/kdf_sp800108.c:#crypto_kdf108_init

On Fri, Dec 10, 2021 at 03:16:34PM +0100, Stephan Mueller wrote:
>
> Herbert, what is your preference in handling this:
> 
> - we could SELECT CRYPTO_SHA256 when the KDF is compiled. This would only be 
> necessary to satisfy the self test. Yet, there is no guarantee that SHA-256 
> would truly be needed because the DH code that calls the KDF obtains the 
> reference to the hash from user space. In the end we could hard compile a 
> crypto algorithm into the kernel that may never be used.

...

> I would prefer to consider the first option to also statically compile 
> SHA-256.

I think KDF800108_CTR should select SHA256 instead of HASH.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt