linux-kernel - Re: [PATCH v3] crypto: hisilicon - replace 'smp_processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 17 Dec 2021 16:14:25 +1100
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Kai Ye <yekai13@...wei.com>
Cc:     linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        wangzhou1@...ilicon.com
Subject: Re: [PATCH v3] crypto: hisilicon - replace 'smp_processor_id' with
 the raw version of the macro

On Mon, Dec 06, 2021 at 06:51:09PM +0800, Kai Ye wrote:
> smp_processor_id() is unsafe if it's used in a preemption-on critical
> section. It will cause the call trace when the preemption-on and sets the
> CONFIG_DEBUG_PREEMPT. So replace 'smp_processor_id' with the raw version of
> the marco in preemptible to avoid the following call trace:

What you wrote here makes zero sense.  If smp_processor_id is
unsafe then the raw version is even more unsafe.

Please provide the actual justification as to why it is *safe*.

Even better, put the justification in the patch as a comment
instead of the changelog.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt