linux-kernel - Re: [PATCH] irq: consider cpus on nodes are unbalanced

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20211217071254.85061-1-yamamoto.rei@jp.fujitsu.com>
Date:   Fri, 17 Dec 2021 16:12:54 +0900
From:   Rei Yamamoto <yamamoto.rei@...fujitsu.com>
To:     ming.lei@...hat.com
Cc:     hch@....de, kbusch@...nel.org, linux-kernel@...r.kernel.org,
        maz@...nel.org, tglx@...utronix.de, yamamoto.rei@...fujitsu.com
Subject: Re: [PATCH] irq: consider cpus on nodes are unbalanced

On Fri, Dec 17, 2021 at 14:57, Ming Lei wrote:
> OK, I can understand the issue now, and only the following part is enough
> since nmsk won't be empty:
> 
> 
> diff --git a/kernel/irq/affinity.c b/kernel/irq/affinity.c
> index f7ff8919dc9b..d2d01565d2ec 100644
> --- a/kernel/irq/affinity.c
> +++ b/kernel/irq/affinity.c
> @@ -269,8 +269,9 @@ static int __irq_build_affinity_masks(unsigned int startvec,
>  	 */
>  	if (numvecs <= nodes) {
>  		for_each_node_mask(n, nodemsk) {
> +			cpumask_and(nmsk, cpu_mask, node_to_cpumask[n]);
>  			cpumask_or(&masks[curvec].mask, &masks[curvec].mask,
> -				   node_to_cpumask[n]);
> +				   nmsk);
>  			if (++curvec == last_affv)
>  				curvec = firstvec;
>  		}

OK, I will repost with the above code changes.

Thanks,
Rei