linux-kernel - Re: [PATCH] crypto: hisilicon/hpre - fix memory leak in hpre_curve25519_src

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211217083940.GF7018@gondor.apana.org.au>
Date:   Fri, 17 Dec 2021 19:39:40 +1100
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Weili Qian <qianweili@...wei.com>
Cc:     davem@...emloft.net, linux-kernel@...r.kernel.org,
        linux-crypto@...r.kernel.org, wangzhou1@...ilicon.com,
        liulongfang@...wei.com
Subject: Re: [PATCH] crypto: hisilicon/hpre - fix memory leak in
 hpre_curve25519_src_init()

On Sat, Dec 11, 2021 at 04:17:19PM +0800, Weili Qian wrote:
> hpre_curve25519_src_init() allocates memory for 'ptr' before calling
> memcmp(). If memcmp() returns 0, the function will return '-EINVAL'
> without freeing memory.
> 
> Signed-off-by: Weili Qian <qianweili@...wei.com>
> ---
>  drivers/crypto/hisilicon/hpre/hpre_crypto.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt