linux-kernel - Re: linux-next: build failure after merge of the gpio-brgl tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=McDv+dF+=5O16TRtPyph0yRNjPNybQ16Jtzkuew9GibvQ@mail.gmail.com>
Date:   Fri, 17 Dec 2021 10:14:05 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Xiang wangx <wangxiang@...rlc.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the gpio-brgl tree

On Fri, Dec 17, 2021 at 7:17 AM Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> Hi all,
>
> On Mon, 13 Dec 2021 19:12:05 -0800 Florian Fainelli <f.fainelli@...il.com> wrote:
> >
> > On 12/13/2021 12:31 PM, broonie@...nel.org wrote:
> > > Hi all,
> > >
> > > After merging the gpio-brgl tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > >
> > > /tmp/next/build/drivers/gpio/gpio-bcm-kona.c:508:34: error: duplicate 'const' declaration specifier [-Werror=duplicate-decl-specifier]
> > >    508 | static const struct of_device_id const bcm_kona_gpio_of_match[] = {
> > >        |                                  ^~~~~
> > > cc1: all warnings being treated as errors
> > >
> > > Caused by commit
> > >
> > >    19784a059cf47b ("gpio: bcm-kona: add const to of_device_id")
> > >
> > > I used the tree from yesterday instead.
> >
> > Doh! Should have double checked the code as the diff was not giving
> > enough context. This patch should simply be dropped, not even build
> > tested by Xiang it seems.
>
> Today, I have reverted that commit.  Please remove or revert it ASAP.
>
> --
> Cheers,
> Stephen Rothwell

Done, sorry for the delay.

Bartosz