linux-kernel - Re: earlyprintk=xdbc seems broken

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2b5c9bb-1b75-bf56-3754-b5b18812d65e@linux.intel.com>
Date:   Fri, 17 Dec 2021 13:01:43 +0200
From:   Mathias Nyman <mathias.nyman@...ux.intel.com>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Dave Hansen <dave.hansen@...el.com>
Cc:     Lu Baolu <baolu.lu@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>, x86@...nel.org,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        Chunfeng Yun <chunfeng.yun@...iatek.com>
Subject: Re: earlyprintk=xdbc seems broken

On 3.12.2021 17.29, Greg KH wrote:
> On Fri, Dec 03, 2021 at 07:22:57AM -0800, Dave Hansen wrote:
>> On 12/3/21 6:31 AM, Mathias Nyman wrote:
>>>>> Can you please see if you can repro and fix this?
>>>>>
>>>>> This all was with current 5.16-rc3 on a tigerlake nuc.
>>>>>
>>>>> Also, perhaps you can update the guide on what sort of setup/cables
>>>>> etc.. you need when either the host or the client is a usb3.1 usb-c only
>>>>> device.
>>>>>
>>>> + Mathias, maybe he still has a USB 3.0 debugging cable.
>>>>
>>> Should have at the office, I'll pick it up next week and try it out.
>>
>> Is someone at Intel responsible for this thing? get_maintainer.pl
>> doesn't think so:
>>
>>> $ perl scripts/get_maintainer.pl ./drivers/usb/early/xhci-dbc.c
>>> Greg Kroah-Hartman <gregkh@...uxfoundation.org> (supporter:USB SUBSYSTEM)
>>> Mike Rapoport <rppt@...nel.org> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:5/5=100%,removed_lines:5/5=100%)
>>> Andrew Morton <akpm@...ux-foundation.org> (commit_signer:1/1=100%)
>>> linux-usb@...r.kernel.org (open list:USB SUBSYSTEM)
>>> linux-kernel@...r.kernel.org (open list)
> 
> Intel is the only one that has this hardware :(
> 
> 

I can reproduce this.
Looks like problems started when driver converted to readl_poll_timeout_atomic() in:

796eed4b2342 usb: early: convert to readl_poll_timeout_atomic()

Seems to hang when read_poll_timeout_atomic() calls ktime_* functions.
Maybe  it's too early for ktime.

After reverting that patch it works again for me.

-Mathias